Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #1

Open
Balastrong opened this issue Aug 10, 2022 · 2 comments
Open

Improve tests #1

Balastrong opened this issue Aug 10, 2022 · 2 comments
Assignees
@Balastrong
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Balastrong
Copy link
Owner

As of v1.0.1 c6fba99 the coverage is already 100% but there are for sure some edge cases that are not covered, for example passing a negative amount to pickMany.

It can be useful to identify such cases and add more tests to validate/strengthen the code.
@Balastrong Balastrong added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2022
@Balastrong Balastrong self-assigned this Mar 20, 2023
@kristynlynn
Copy link

Mind if I look at this? I think I have a few tests I can think of that would be worth adding.

@Balastrong
Copy link
Owner Author

Hey @kristynlynn! Sure, I'll be happy to review your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balastrong Balastrong

Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Balastrong @kristynlynn