Fixed many of the warnings after scala 2.13 upgrade

yadavan88 · yadavan88 · commit 8c7131d5e1be · 2023-01-19T20:36:05.000+01:00
diff --git a/build.sbt b/build.sbt
@@ -134,12 +134,13 @@ lazy val scala_core_collections = (project in file("scala-core-collections"))
     )
   )
 
-lazy val scala_core_collections_2 = (project in file("scala-core-collections-2"))
-  .settings(
-    name := "scala-core-collections-2",
-    libraryDependencies +=
-      "org.scalatest" %% "scalatest" % "3.2.14" % Test
-  )
+lazy val scala_core_collections_2 =
+  (project in file("scala-core-collections-2"))
+    .settings(
+      name := "scala-core-collections-2",
+      libraryDependencies +=
+        "org.scalatest" %% "scalatest" % "3.2.14" % Test
+    )
 
 lazy val scala_test = (project in file("scala-test"))
   .settings(
@@ -330,11 +331,11 @@ lazy val scala_libraries_4 = (project in file("scala-libraries-4"))
       "org.scala-lang" % "scala-reflect" % scalaVersion.value % Provided,
       "org.tpolecat" %% "skunk-core" % "0.3.2"
     ),
-     libraryDependencies ++= Seq(
+    libraryDependencies ++= Seq(
       "org.apache.spark" %% "spark-core" % sparkVersion,
       "org.apache.spark" %% "spark-sql" % sparkVersion
     ),
-    scalacOptions += "-Xasync"
+    //scalacOptions += "-Xasync"
   )
 
 lazy val scala_strings = (project in file("scala-strings"))
@@ -414,4 +415,4 @@ lazy val scala212 = (project in file("scala212"))
     libraryDependencies ++= Seq(
       scalaTest
     )
-  )
+  )
diff --git a/cats-effects/src/main/scala/com/baeldung/scala/resources/ResourceHandling.scala b/cats-effects/src/main/scala/com/baeldung/scala/resources/ResourceHandling.scala
@@ -1,12 +1,9 @@
 package com.baeldung.scala.resources
 
-import cats.effect.IO
-import java.io.File
-import scala.io.Source
-import cats.effect.IOApp
-import scala.io.BufferedSource
+import cats.effect.{IO, IOApp, Resource}
+
 import java.io.FileWriter
-import cats.effect.Resource
+import scala.io.Source
 
 object ResourceHandling extends IOApp.Simple {
 
diff --git a/scala-akka-2/src/main/scala/com/baeldung/scala/akka/http/MovieService.scala b/scala-akka-2/src/main/scala/com/baeldung/scala/akka/http/MovieService.scala
@@ -1,7 +1,6 @@
 package com.baeldung.scala.akka.http
-import scala.concurrent.Future
-import scala.collection.mutable.ListBuffer
 import scala.concurrent.ExecutionContext.Implicits.global
+import scala.concurrent.Future
 
 case class Movie(id: Int, name: String, length: Int)
 
diff --git a/scala-akka/src/main/scala/com/baeldung/scala/akka/alpakka/AlpakkaMongoIntegration.scala b/scala-akka/src/main/scala/com/baeldung/scala/akka/alpakka/AlpakkaMongoIntegration.scala
@@ -1,7 +1,5 @@
 package com.baeldung.scala.akka.alpakka
 
-import java.nio.file.FileSystems
-
 import akka.NotUsed
 import akka.stream.alpakka.mongodb.scaladsl.MongoSink
 import akka.stream.scaladsl.Source
diff --git a/scala-akka/src/main/scala/com/baeldung/scala/akka/scheduler/Greetings.scala b/scala-akka/src/main/scala/com/baeldung/scala/akka/scheduler/Greetings.scala
@@ -8,6 +8,6 @@ final case class Greeted(msg: String)
 class Greetings extends Actor {
   override def receive: Receive = {
     case greet: Greet =>
-      sender ! Greeted(s"${greet.by}: Hello, ${greet.to}")
+      sender() ! Greeted(s"${greet.by}: Hello, ${greet.to}")
   }
 }
diff --git a/scala-akka/src/main/scala/com/baeldung/scala/akka/stopping/MessageProcessorActor.scala b/scala-akka/src/main/scala/com/baeldung/scala/akka/stopping/MessageProcessorActor.scala
@@ -1,10 +1,6 @@
 package com.baeldung.scala.akka.stopping
 
 import akka.actor.Actor
-import akka.actor.ActorSystem
-import akka.actor.Props
-import akka.actor.PoisonPill
-import akka.actor.DeadLetter
 
 object MessageProcessorActor {
   trait Message
@@ -19,7 +15,7 @@ class MessageProcessorActor extends Actor {
 
   override def receive: Receive = {
     case msg: MessageProcessorActor.Greet =>
-      sender ! MessageProcessorActor.Reply("Hey, " + msg.msg)
+      sender() ! MessageProcessorActor.Reply("Hey, " + msg.msg)
   }
 
 }
diff --git a/scala-akka/src/main/scala/com/baeldung/scala/akka/supervision/SupervisionApplication.scala b/scala-akka/src/main/scala/com/baeldung/scala/akka/supervision/SupervisionApplication.scala
@@ -10,7 +10,7 @@ import com.baeldung.scala.akka.supervision.SupervisionApplication.Filesystem.{Fs
 import com.baeldung.scala.akka.supervision.SupervisionApplication.WebServer.Request
 
 import scala.concurrent.duration.DurationInt
-import scala.util.{Failure, Random, Success, Try}
+import scala.util.{Failure, Success, Try}
 
 object SupervisionApplication {
 
diff --git a/scala-core-2/src/main/scala/com/baeldung/scala/concurrency/FutureAndPromise.scala b/scala-core-2/src/main/scala/com/baeldung/scala/concurrency/FutureAndPromise.scala
@@ -53,7 +53,7 @@ object ScalaAndPromise {
     } yield User(name, email, hashedPassword, avatar)
 
   def runByPromise[T](block: => T)(implicit ec: ExecutionContext): Future[T] = {
-    val p = Promise[T]
+    val p = Promise[T]()
     ec.execute { () =>
       try {
         p.success(block)
diff --git a/scala-core-2/src/main/scala/com/baeldung/scala/exceptionhandling/ExceptionHandling.scala b/scala-core-2/src/main/scala/com/baeldung/scala/exceptionhandling/ExceptionHandling.scala
@@ -21,7 +21,7 @@ object ExceptionHandling {
     try {
       divide(a, 0)
     } catch {
-      case e: DivideByZero => null
+      case _: DivideByZero => null
     } finally {
       println("Finished")
     }
diff --git a/scala-core-3/src/main/scala/com/baeldung/scala/await/AwaitFuture.scala b/scala-core-3/src/main/scala/com/baeldung/scala/await/AwaitFuture.scala
@@ -1,16 +1,16 @@
 package com.baeldung.scala.await
 
-import scala.concurrent.{ Await, Future }
-import scala.io.Source
 import scala.concurrent.ExecutionContext.Implicits.global
+import scala.concurrent.Future
+import scala.io.Source
 
 object AwaitFuture  {
 
   def fetchDataFromUrl(url : String) : Future[String] = Future {
     Source.fromURL(url).getLines().mkString
   }
 
-  def fetchDataFrom(url : String, waitTime : Long = 0l) : Future[String] =  Future {
+  def fetchDataFrom(url : String, waitTime : Long = 0L) : Future[String] =  Future {
     Thread.sleep(waitTime)
     Source.fromURL(url).getLines().mkString
   }
diff --git a/scala-core-3/src/main/scala/com/baeldung/scala/typecasts/ErrorHandling.scala b/scala-core-3/src/main/scala/com/baeldung/scala/typecasts/ErrorHandling.scala
@@ -33,7 +33,7 @@ object ErrorHandling extends App {
     case Failure(e: UnknownHostException) =>
       println(s"Unknown host specified: ${e.getMessage}")
     case Failure(e: IOException) =>
-      println("Network failure: ${e.getMessage}")
+      println(s"Network failure: ${e.getMessage}")
     case Failure(t) =>
       t.printStackTrace()
   }
diff --git a/scala-core-4/src/main/scala/com/baeldung/scala/assertvsrequire/RequireUsage.scala b/scala-core-4/src/main/scala/com/baeldung/scala/assertvsrequire/RequireUsage.scala
@@ -12,7 +12,7 @@ object RequireUsage extends App {
     issueDrivingLicense("Jr. Darwin", 5) // prints "Failed in require precondition"
   } catch {
     case e: IllegalArgumentException =>
-      println("Failed in require precondition")
+      println("Failed in require precondition-"+e.getMessage)
   }
 
 }
diff --git a/scala-core-5/src/main/scala/com/baeldung/scala/datesandtimes/JavaUtilDate.scala b/scala-core-5/src/main/scala/com/baeldung/scala/datesandtimes/JavaUtilDate.scala
@@ -3,7 +3,6 @@ import java.text.SimpleDateFormat
 
 import scala.concurrent.duration.Duration
 import scala.concurrent.{Await, Future}
-import scala.languageFeature.experimental.macros
 
 object JavaUtilDate extends App{
 
@@ -29,5 +28,5 @@ object JavaUtilDate extends App{
   val date1 = Await.result(r1, Duration.Inf)
   val date2 = Await.result(r2, Duration.Inf)
 
-  println(date1, date2) // Prints "Wed Jul 01 2020, Fri Aug 21 2020"
+  println(date1 +", "+ date2) // Prints "Wed Jul 01 2020, Fri Aug 21 2020"
 }
diff --git a/scala-core/src/main/scala/com/baeldung/scala/exceptionhandling/Examples.scala b/scala-core/src/main/scala/com/baeldung/scala/exceptionhandling/Examples.scala
@@ -1,6 +1,6 @@
 package com.baeldung.scala.exceptionhandling
 
-import scala.util.{Failure, Success, Try, control}
+import scala.util.Try
 import scala.util.control.Exception._
 
 object Examples {
diff --git a/scala-design-patterns/src/main/scala/com/baeldung/scala/cakepattern/CakePattern.scala b/scala-design-patterns/src/main/scala/com/baeldung/scala/cakepattern/CakePattern.scala
@@ -1,6 +1,6 @@
 package com.baeldung.scala.cakepattern
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 object CakePattern {
 
diff --git a/scala-lang-2/src/main/scala/com/baeldung/scala/voidtypes/UnitReturnType.scala b/scala-lang-2/src/main/scala/com/baeldung/scala/voidtypes/UnitReturnType.scala
@@ -10,7 +10,7 @@ object UnitReturnType extends App{
   println("result of function returning Unit: %s".format(functionReturnUnit))
 
   def functionReturnImplicitUnit{
-    """
+    s"""
       do something, don't return anything
     """
   }
diff --git a/scala-libraries-2/src/main/scala/com/baeldung/cache/service/AsyncQueryMemoizeService.scala b/scala-libraries-2/src/main/scala/com/baeldung/cache/service/AsyncQueryMemoizeService.scala
@@ -4,7 +4,6 @@ import scalacache._
 import scalacache.guava._
 import com.google.common.cache.CacheBuilder
 import scalacache.modes.scalaFuture._
-import scalacache.serialization.binary._
 import scalacache.memoization._
 import scala.concurrent.ExecutionContext.Implicits.global
 
diff --git a/scala-libraries-2/src/main/scala/com/baeldung/cache/service/CatsService.scala b/scala-libraries-2/src/main/scala/com/baeldung/cache/service/CatsService.scala
@@ -5,7 +5,6 @@ import com.google.common.cache.CacheBuilder
 import scalacache._
 import scalacache.memoization._
 import scalacache.guava.GuavaCache
-import scala.concurrent.duration._
 
 object GuavaCacheCatsConfig {
   val underlyingGuavaCacheCats =
diff --git a/scala-libraries-2/src/main/scala/com/baeldung/cache/service/SyncQueryCustomMemoizeKeyService.scala b/scala-libraries-2/src/main/scala/com/baeldung/cache/service/SyncQueryCustomMemoizeKeyService.scala
@@ -1,12 +1,10 @@
 package com.baeldung.cache.service
 
+import com.google.common.cache.CacheBuilder
 import scalacache._
 import scalacache.guava._
-import com.google.common.cache.CacheBuilder
-import scalacache.memoization.MethodCallToStringConverter.onlyMethodParams
-import scalacache.modes.sync._
-import scalacache.serialization.binary._
 import scalacache.memoization._
+import scalacache.modes.sync._
 
 import scala.concurrent.duration._
 
diff --git a/scala-libraries-2/src/main/scala/com/baeldung/cache/service/SyncQueryMemoizeService.scala b/scala-libraries-2/src/main/scala/com/baeldung/cache/service/SyncQueryMemoizeService.scala
@@ -1,13 +1,12 @@
 package com.baeldung.cache.service
 
+import com.google.common.cache.CacheBuilder
 import scalacache._
 import scalacache.guava._
-import com.google.common.cache.CacheBuilder
-import scalacache.serialization.binary._
 import scalacache.memoization._
 
 import scala.concurrent.duration._
-import scala.util.{Failure, Try}
+import scala.util.Try
 
 object GuavaCacheMemoizationConfig {
   val memoizedUnderlyingGuavaCache =
@@ -18,8 +17,8 @@ object GuavaCacheMemoizationConfig {
 }
 
 class SyncQueryMemoizeService {
-  import scalacache.modes.sync._
   import GuavaCacheMemoizationConfig._
+  import scalacache.modes.sync._
 
   var queryCount = 0
 
@@ -44,8 +43,8 @@ class SyncQueryMemoizeService {
 }
 
 class TryMemoizeService {
-  import scalacache.modes.try_._
   import GuavaCacheMemoizationConfig._
+  import scalacache.modes.try_._
 
   var queryCount = 0
   var failQueryCount = 0
diff --git a/scala-libraries-3/src/main/scala/com/baeldung/scala/pureconfig/Configs.scala b/scala-libraries-3/src/main/scala/com/baeldung/scala/pureconfig/Configs.scala
@@ -3,13 +3,11 @@ package com.baeldung.pureconfig
 import enumeratum._
 import pureconfig._
 import pureconfig.configurable._
-import pureconfig.generic.auto._
 import pureconfig.generic.semiauto._
 
-import java.time.{LocalDate, LocalDateTime}
+import java.time.LocalDate
 import java.time.format.DateTimeFormatter
 import scala.concurrent.duration.FiniteDuration
-import pureconfig.module.enumeratum._
 
 sealed trait Protocol
 object Protocol {
@@ -53,11 +51,6 @@ object Env extends Enum[Env] {
 final case class BaseAppConfig(appName: String, baseDate: LocalDate, env: Env)
 
 
-import pureconfig._
-import pureconfig.generic.auto._
-import pureconfig.module.enumeratum._
-import com.typesafe.config.ConfigFactory.parseString
-import enumeratum._
 import enumeratum.EnumEntry._
 
 sealed trait Greeting extends EnumEntry with Snakecase
diff --git a/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/RDDToDataframe.scala b/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/RDDToDataframe.scala
@@ -6,7 +6,7 @@ import org.apache.spark.rdd.RDD
 
 object RDDToDataframe extends App{
 
-  val spark: SparkSession = SparkSession.builder.master("local").getOrCreate
+  val spark: SparkSession = SparkSession.builder().master("local").getOrCreate
   val sc = spark.sparkContext
 
   val rdd = sc.parallelize(
diff --git a/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/rdd/PrintRDD.scala b/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/rdd/PrintRDD.scala
@@ -3,7 +3,7 @@ package com.baeldung.scala.spark.rdd
 import org.apache.spark.sql.SparkSession
 
 object PrintRDD extends App {
-  val spark: SparkSession = SparkSession.builder.master("local").getOrCreate
+  val spark: SparkSession = SparkSession.builder().master("local").getOrCreate
   import spark.implicits._
 
   val numbers = List(4, 6, 1, 7, 12, 2)
diff --git a/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/rdd/RDDTutorial.scala b/scala-libraries-3/src/main/scala/com/baeldung/scala/spark/rdd/RDDTutorial.scala
@@ -5,7 +5,7 @@ import org.apache.spark.rdd.RDD
 import org.apache.spark.sql.SparkSession
 
 object RDDTutorial extends App {
-  val spark: SparkSession = SparkSession.builder.master("local").getOrCreate
+  val spark: SparkSession = SparkSession.builder().master("local").getOrCreate
   val sc: SparkContext = spark.sparkContext
 
   val animals = List("dog", "cat", "frog", "horse")
@@ -14,8 +14,8 @@ object RDDTutorial extends App {
   val countLengthRDD = animalsRDD.map(animal => (animal, animal.length))
   val noCRDD = animalsRDD.filter(_.startsWith("c"))
 
-  countLengthRDD.collect
-  noCRDD.collect
+  countLengthRDD.collect()
+  noCRDD.collect()
 
   val numbers = sc.parallelize(List(1, 2, 3, 4, 5))
   val numbersSum = numbers.reduce(_ + _)
diff --git a/scala-libraries-os/src/main/scala/com/baeldung/scala/os/ScalaSysApp.scala b/scala-libraries-os/src/main/scala/com/baeldung/scala/os/ScalaSysApp.scala
@@ -14,6 +14,6 @@ object ScalaSysApp extends App {
   val resultErr = "ls -l dir".!
 
   val source = Source.fromFile("./LICENSE")
-  val lines = source.getLines.size
+  val lines = source.getLines().size
   source.close()
 }
diff --git a/scala-libraries/src/main/scala/com/baeldung/scala/fs2/Fs2Examples.scala b/scala-libraries/src/main/scala/com/baeldung/scala/fs2/Fs2Examples.scala
@@ -1,14 +1,9 @@
 package com.baeldung.scala.fs2
 
-import java.io.{File, PrintWriter}
-import java.nio.file.Paths
-
 import cats.effect.{Async, Blocker, ContextShift, IO}
-
-import scala.util.Random
 import fs2._
 
-import scala.collection.mutable
+import java.nio.file.Paths
 
 object Fs2Examples {
 
diff --git a/zio/src/main/scala/com/baeldung/scala/zio/resources/ResourceHandling.scala b/zio/src/main/scala/com/baeldung/scala/zio/resources/ResourceHandling.scala
@@ -18,7 +18,7 @@ object ResourceHandling extends ZIOAppDefault {
   val complexZIO = simpleZIO *> failingZIO *> ZIO.succeed(println("Final step in chain"))
   val complexZIOWithFinalizer = complexZIO.ensuring(finalizerBlock)
 
-  val finalizer2 = ZIO.suspend {
+  val finalizer2: RIO[String, Nothing] = ZIO.suspend {
     throw new Exception
   }
 

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@ final case class Greeted(msg: String)`
`8`	`8`	`class Greetings extends Actor {`
`9`	`9`	`override def receive: Receive = {`
`10`	`10`	`case greet: Greet =>`
`11`		`- sender ! Greeted(s"${greet.by}: Hello, ${greet.to}")`
	`11`	`+ sender() ! Greeted(s"${greet.by}: Hello, ${greet.to}")`
`12`	`12`	`}`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ object ExceptionHandling {`
`21`	`21`	`try {`
`22`	`22`	`divide(a, 0)`
`23`	`23`	`} catch {`
`24`		`- case e: DivideByZero => null`
	`24`	`+ case _: DivideByZero => null`
`25`	`25`	`} finally {`
`26`	`26`	`println("Finished")`
`27`	`27`	`}`