Skip to content

Commit 8c7131d

Browse files
committed
Fixed many of the warnings after scala 2.13 upgrade
1 parent 7380258 commit 8c7131d

File tree

27 files changed

+43
-70
lines changed

27 files changed

+43
-70
lines changed

build.sbt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,13 @@ lazy val scala_core_collections = (project in file("scala-core-collections"))
134134
)
135135
)
136136

137-
lazy val scala_core_collections_2 = (project in file("scala-core-collections-2"))
138-
.settings(
139-
name := "scala-core-collections-2",
140-
libraryDependencies +=
141-
"org.scalatest" %% "scalatest" % "3.2.14" % Test
142-
)
137+
lazy val scala_core_collections_2 =
138+
(project in file("scala-core-collections-2"))
139+
.settings(
140+
name := "scala-core-collections-2",
141+
libraryDependencies +=
142+
"org.scalatest" %% "scalatest" % "3.2.14" % Test
143+
)
143144

144145
lazy val scala_test = (project in file("scala-test"))
145146
.settings(
@@ -330,11 +331,11 @@ lazy val scala_libraries_4 = (project in file("scala-libraries-4"))
330331
"org.scala-lang" % "scala-reflect" % scalaVersion.value % Provided,
331332
"org.tpolecat" %% "skunk-core" % "0.3.2"
332333
),
333-
libraryDependencies ++= Seq(
334+
libraryDependencies ++= Seq(
334335
"org.apache.spark" %% "spark-core" % sparkVersion,
335336
"org.apache.spark" %% "spark-sql" % sparkVersion
336337
),
337-
scalacOptions += "-Xasync"
338+
//scalacOptions += "-Xasync"
338339
)
339340

340341
lazy val scala_strings = (project in file("scala-strings"))
@@ -414,4 +415,4 @@ lazy val scala212 = (project in file("scala212"))
414415
libraryDependencies ++= Seq(
415416
scalaTest
416417
)
417-
)
418+
)

cats-effects/src/main/scala/com/baeldung/scala/resources/ResourceHandling.scala

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
package com.baeldung.scala.resources
22

3-
import cats.effect.IO
4-
import java.io.File
5-
import scala.io.Source
6-
import cats.effect.IOApp
7-
import scala.io.BufferedSource
3+
import cats.effect.{IO, IOApp, Resource}
4+
85
import java.io.FileWriter
9-
import cats.effect.Resource
6+
import scala.io.Source
107

118
object ResourceHandling extends IOApp.Simple {
129

scala-akka-2/src/main/scala/com/baeldung/scala/akka/http/MovieService.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.baeldung.scala.akka.http
2-
import scala.concurrent.Future
3-
import scala.collection.mutable.ListBuffer
42
import scala.concurrent.ExecutionContext.Implicits.global
3+
import scala.concurrent.Future
54

65
case class Movie(id: Int, name: String, length: Int)
76

scala-akka/src/main/scala/com/baeldung/scala/akka/alpakka/AlpakkaMongoIntegration.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.baeldung.scala.akka.alpakka
22

3-
import java.nio.file.FileSystems
4-
53
import akka.NotUsed
64
import akka.stream.alpakka.mongodb.scaladsl.MongoSink
75
import akka.stream.scaladsl.Source

scala-akka/src/main/scala/com/baeldung/scala/akka/scheduler/Greetings.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ final case class Greeted(msg: String)
88
class Greetings extends Actor {
99
override def receive: Receive = {
1010
case greet: Greet =>
11-
sender ! Greeted(s"${greet.by}: Hello, ${greet.to}")
11+
sender() ! Greeted(s"${greet.by}: Hello, ${greet.to}")
1212
}
1313
}

scala-akka/src/main/scala/com/baeldung/scala/akka/stopping/MessageProcessorActor.scala

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
package com.baeldung.scala.akka.stopping
22

33
import akka.actor.Actor
4-
import akka.actor.ActorSystem
5-
import akka.actor.Props
6-
import akka.actor.PoisonPill
7-
import akka.actor.DeadLetter
84

95
object MessageProcessorActor {
106
trait Message
@@ -19,7 +15,7 @@ class MessageProcessorActor extends Actor {
1915

2016
override def receive: Receive = {
2117
case msg: MessageProcessorActor.Greet =>
22-
sender ! MessageProcessorActor.Reply("Hey, " + msg.msg)
18+
sender() ! MessageProcessorActor.Reply("Hey, " + msg.msg)
2319
}
2420

2521
}

scala-akka/src/main/scala/com/baeldung/scala/akka/supervision/SupervisionApplication.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import com.baeldung.scala.akka.supervision.SupervisionApplication.Filesystem.{Fs
1010
import com.baeldung.scala.akka.supervision.SupervisionApplication.WebServer.Request
1111

1212
import scala.concurrent.duration.DurationInt
13-
import scala.util.{Failure, Random, Success, Try}
13+
import scala.util.{Failure, Success, Try}
1414

1515
object SupervisionApplication {
1616

scala-core-2/src/main/scala/com/baeldung/scala/concurrency/FutureAndPromise.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ object ScalaAndPromise {
5353
} yield User(name, email, hashedPassword, avatar)
5454

5555
def runByPromise[T](block: => T)(implicit ec: ExecutionContext): Future[T] = {
56-
val p = Promise[T]
56+
val p = Promise[T]()
5757
ec.execute { () =>
5858
try {
5959
p.success(block)

scala-core-2/src/main/scala/com/baeldung/scala/exceptionhandling/ExceptionHandling.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ object ExceptionHandling {
2121
try {
2222
divide(a, 0)
2323
} catch {
24-
case e: DivideByZero => null
24+
case _: DivideByZero => null
2525
} finally {
2626
println("Finished")
2727
}

scala-core-3/src/main/scala/com/baeldung/scala/await/AwaitFuture.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
package com.baeldung.scala.await
22

3-
import scala.concurrent.{ Await, Future }
4-
import scala.io.Source
53
import scala.concurrent.ExecutionContext.Implicits.global
4+
import scala.concurrent.Future
5+
import scala.io.Source
66

77
object AwaitFuture {
88

99
def fetchDataFromUrl(url : String) : Future[String] = Future {
1010
Source.fromURL(url).getLines().mkString
1111
}
1212

13-
def fetchDataFrom(url : String, waitTime : Long = 0l) : Future[String] = Future {
13+
def fetchDataFrom(url : String, waitTime : Long = 0L) : Future[String] = Future {
1414
Thread.sleep(waitTime)
1515
Source.fromURL(url).getLines().mkString
1616
}

0 commit comments

Comments
 (0)