Merge pull request #92 from Backbase/ssdk16-review

fix ArchUnit violations

Author: miladbb

service-sdk/16.0.0/add-persistence-to-service/example-persistence-service/src/main/java/com/backbase/example/ExampleController.java renamed to service-sdk/16.0.0/add-persistence-to-service/example-persistence-service/src/main/java/com/backbase/example/api/ExampleController.java

@@ -1,5 +1,6 @@
-package com.backbase.example;
+package com.backbase.example.api;
 
+import com.backbase.example.Message;
 import com.backbase.example.domain.Greeting;
 import com.backbase.example.mapper.GreetingsMapper;
 import com.backbase.example.service.GreetingsService;

service-sdk/16.0.0/add-persistence-to-service/example-persistence-service/src/main/java/com/backbase/example/mapper/GreetingsMapper.java

@@ -3,11 +3,12 @@
 import com.backbase.example.Message;
 import com.backbase.example.domain.Greeting;
 import org.mapstruct.Mapper;
+import org.mapstruct.ReportingPolicy;
 import org.mapstruct.factory.Mappers;
 
 import java.util.List;
 
-@Mapper
+@Mapper(unmappedTargetPolicy= ReportingPolicy.ERROR)
 public interface GreetingsMapper {
 
     GreetingsMapper INSTANCE = Mappers.getMapper( GreetingsMapper.class);

service-sdk/16.0.0/add-persistence-to-service/example-persistence-service/src/main/java/com/backbase/example/service/GreetingsServiceImpl.java

@@ -2,29 +2,43 @@
 
 import com.backbase.example.domain.Greeting;
 import com.backbase.example.repository.GreetingsRepository;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.security.access.prepost.PreAuthorize;
 import org.springframework.stereotype.Service;
 
 import java.util.List;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
+@Transactional(readOnly=true)
 public class GreetingsServiceImpl implements GreetingsService {
 
+    private static final Logger log = LoggerFactory.getLogger(GreetingsServiceImpl.class);
+
     @Autowired
     private GreetingsRepository greetingsRepository;
 
     @Override
+    @PreAuthorize("permitAll()")
     public List<Greeting> getGreetings() {
+        log.debug("Service getGreetings is called {}", 1);
         return greetingsRepository.findAll();
     }
 
     @Override
+    @PreAuthorize("permitAll()")
     public Greeting getGreetingById(String id) {
+        log.debug("Service getGreetingById is called {}", id);
         return greetingsRepository.findById(id).get();
     }
 
     @Override
+    @PreAuthorize("permitAll()")
+    @Transactional
     public void addNewGreeting(Greeting greeting) {
+        log.debug("Service addNewGreeting is called {}", 1);
         greetingsRepository.save(greeting);
     }
 }

service-sdk/16.0.0/create-core-service/example-core-service/src/main/java/com/backbase/example/ExampleController.java renamed to service-sdk/16.0.0/create-core-service/example-core-service/src/main/java/com/backbase/example/api/ExampleController.java

@@ -1,5 +1,6 @@
-package com.backbase.example;
+package com.backbase.example.api;
 
+import com.backbase.example.Message;
 import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.bind.annotation.RequestMapping;

service-sdk/16.0.0/create-openapi-client/banking-service/src/main/java/com/backbase/banking/ExampleController.java renamed to service-sdk/16.0.0/create-openapi-client/banking-service/src/main/java/com/backbase/banking/api/ExampleController.java

@@ -1,5 +1,6 @@
-package com.backbase.banking;
+package com.backbase.banking.api;
 
+import com.backbase.banking.Message;
 import com.backbase.messaging.api.client.v2.MessageApi;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;

service-sdk/16.0.0/create-openapi-client/banking-service/src/main/java/com/backbase/banking/MessagingServiceRestClientConfiguration.java renamed to service-sdk/16.0.0/create-openapi-client/banking-service/src/main/java/com/backbase/banking/config/MessagingServiceRestClientConfiguration.java

@@ -1,15 +1,17 @@
-package com.backbase.banking;
+package com.backbase.banking.config;
 
 import com.backbase.buildingblocks.communication.client.ApiClientConfig;
 import com.backbase.buildingblocks.communication.http.HttpCommunicationConfiguration;
 import com.backbase.messaging.api.client.ApiClient;
 import com.backbase.messaging.api.client.v2.MessageApi;
 import org.springframework.context.annotation.*;
 import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.validation.annotation.Validated;
 
 // tag::MessagingServiceRestClientConfiguration[]
 @Configuration
 @ConfigurationProperties("backbase.communication.services.name")
+@Validated
 public class MessagingServiceRestClientConfiguration extends ApiClientConfig {
 
     public static final String MESSAGING_SERVICE_ID = "messaging-service";

service-sdk/16.0.0/create-openapi-spec-project/messaging-api/pom.xml

@@ -74,6 +74,7 @@
                             <output>${project.basedir}/target/boat-lint-reports</output>
                             <writeLintReport>true</writeLintReport>
                             <failOnWarning>true</failOnWarning>
+                            <ignoreRules>219,215,218,115,134,104,105,110,176,M011,151,S007,S005,B013,H001</ignoreRules>
                         </configuration>
                     </execution>
                     <execution>

service-sdk/16.0.0/create-openapi-spec-project/messaging-service/pom.xml

@@ -22,7 +22,7 @@
     <properties>
         <java.version>17</java.version>
         <boat-maven-plugin.version>0.17.5</boat-maven-plugin.version>
-]    </properties>
+    </properties>
 
     <dependencies>
         <!-- tag::openapi-dependency[] -->

service-sdk/16.0.0/create-openapi-spec-project/messaging-service/src/main/java/com/backbase/message/ExampleController.java renamed to service-sdk/16.0.0/create-openapi-spec-project/messaging-service/src/main/java/com/backbase/message/api/ExampleController.java

@@ -1,4 +1,4 @@
-package com.backbase.message;
+package com.backbase.message.api;
 
 import com.backbase.dbs.messaging_service.api.service.v2.MessageApi;
 import com.backbase.dbs.messaging_service.api.service.v2.model.MessagePostResponseBody;

service-sdk/16.0.0/create-outbound-integration-service-openapi/example-integration-openapi-service/src/main/java/com/backbase/example/ExampleController.java renamed to service-sdk/16.0.0/create-outbound-integration-service-openapi/example-integration-openapi-service/src/main/java/com/backbase/example/api/ExampleController.java

@@ -1,9 +1,9 @@
-package com.backbase.example;
+package com.backbase.example.api;
 
 import com.backbase.buildingblocks.presentation.errors.InternalServerErrorException;
 import com.backbase.example.api.client.v1.MessageApi;
 import com.backbase.example.api.client.v1.model.MessagePostResponseBody;
-import com.backbase.example.integration.MessageClient;
+import com.backbase.example.client.MessageClient;
 import com.backbase.example.mapper.IntegrationMessageMapper;
 import com.backbase.example.model.Message;
 import java.io.IOException;