[ci][linux] build client and manager for arm64 #6587

AenBleidd · 2025-10-03T00:53:13Z

No description provided.

Copilot

Pull Request Overview

This PR modifies the Linux build system to support building BOINC client and manager components for the arm64 architecture using vcpkg, extending the existing CI infrastructure.

Refactors existing vcpkg update scripts to accept architecture triplets as parameters
Adds new build configurations for arm64 client and manager builds
Updates CI workflow and deployment scripts to include arm64 variants

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
linux/update_vcpkg_libs.sh	Added copyright header and parameterized triplet support
linux/update_vcpkg_client.sh	Added copyright header and parameterized triplet support
linux/update_vcpkg_apps.sh	Added copyright header and parameterized triplet support
linux/arm64/update_vcpkg_libs.sh	Removed duplicate arm64-specific script
linux/arm64/update_vcpkg_apps.sh	Removed duplicate arm64-specific script
linux/arm64/ci_configure_manager.sh	New arm64 manager build configuration script
linux/arm64/ci_configure_libs.sh	Updated to use parameterized vcpkg script
linux/arm64/ci_configure_client.sh	New arm64 client build configuration script
linux/arm64/ci_configure_apps.sh	Updated to use parameterized vcpkg script with copyright header
deploy/prepare_deployment.py	Added arm64 deployment functions and reorganized build types
.github/workflows/linux.yml	Added arm64 client/manager build jobs and improved build parallelization

Comments suppressed due to low confidence (1)

linux/arm64/ci_configure_client.sh:1

Incorrect script reference. This should be linux/update_vcpkg_client.sh $TRIPLET since this is configuring the client, not the manager.

#!/bin/sh

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

linux/update_vcpkg_libs.sh

linux/update_vcpkg_client.sh

linux/update_vcpkg_apps.sh

linux/arm64/ci_configure_apps.sh

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

linux/arm64/ci_configure_apps.sh

linux/arm64/ci_configure_client.sh

linux/arm64/ci_configure_manager.sh

linux/arm64/ci_configure_libs.sh

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-03T17:11:50Z

linux/arm64/ci_configure_manager.sh

+export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET"
+export PKG_CONFIG_PATH=/usr/lib/aarch64-linux-gnu/pkgconfig/:$VCPKG_DIR/lib/pkgconfig/:$PKG_CONFIG_PATH
+
+linux/update_vcpkg_manager.sh $TRIPLET


The script calls 'linux/update_vcpkg_manager.sh' but this file doesn't appear to exist in the codebase. Based on the pattern in other files, this should likely be 'linux/update_vcpkg_libs.sh' for manager builds.

Suggested change

linux/update_vcpkg_manager.sh $TRIPLET

linux/update_vcpkg_libs.sh $TRIPLET

Copilot

Pull Request Overview

Copilot reviewed 44 out of 44 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-05T16:36:02Z

deploy/prepare_deployment.py

 boinc_types = {
-    'linux_client': prepare_linux_client,
-    'linux_client-vcpkg': prepare_linux_client_vcpkg,
+    'android_apps': prepare_android_apps,
    'linux_apps': prepare_linux_apps,
    'linux_apps-arm64': prepare_linux_apps_arm64,
-    'linux_apps-vcpkg-arm64': prepare_linux_apps_vcpkg_arm64,
    'linux_apps-vcpkg': prepare_linux_apps_vcpkg,
+    'linux_apps-vcpkg-arm64': prepare_linux_apps_vcpkg_arm64,
+    'linux_client': prepare_linux_client,
+    'linux_client-vcpkg': prepare_linux_client_vcpkg,
+    'linux_client-vcpkg-arm64': prepare_linux_client_vcpkg_arm64,
    'linux_manager': prepare_linux_manager,
    'linux_manager-with-webview': prepare_linux_manager_with_webview,
    'linux_manager-with-webview-vcpkg': prepare_linux_manager_with_webview_vcpkg,
+    'linux_manager-with-webview-vcpkg-arm64': prepare_linux_manager_with_webview_vcpkg_arm64,
    'linux_manager-without-webview': prepare_linux_manager_without_webview,
+    'logs': prepare_logs,
+    'macos_manager': prepare_macos_apps,
+    'macos_samples-makefile': prepare_macos_makefile_apps,
+    'win_apps': prepare_win_apps,
    'win_apps-mingw': prepare_win_apps_mingw,
    'win_apps-mingw-vcpkg': prepare_win_apps_mingw_vcpkg,
-    'android_apps': prepare_android_apps,
-    'win_apps': prepare_win_apps,
    'win_client': prepare_win_client,
-    'win_manager': prepare_win_manager,
    'win_installer': prepare_win_installer,
-    'macos_manager': prepare_macos_apps,
-    'macos_samples-makefile': prepare_macos_makefile_apps,
-    'logs': prepare_logs,
+    'win_manager': prepare_win_manager,
 }


[nitpick] The reorganization of the boinc_types dictionary by platform improves maintainability, but the alphabetical sorting within each platform section could be more consistent. Consider sorting all entries alphabetically within each platform grouping.

linux/arm64/ci_configure_client.sh

linux/arm64/ci_configure_manager.sh

linux/arm64/ci_configure_libs.sh

linux/arm64/ci_configure_apps.sh

Copilot

Pull Request Overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated 7 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T02:22:21Z

linux/update_vcpkg_libs.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use [ -n "$1" ] instead of [ ! -z "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot · 2025-10-06T02:22:21Z

linux/update_vcpkg_client.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use [ -n "$1" ] instead of [ ! -z "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot · 2025-10-06T02:22:21Z

linux/update_vcpkg_apps.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use [ -n "$1" ] instead of [ ! -z "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot · 2025-10-06T02:22:22Z

linux/arm64/ci_configure_libs.sh

+export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET"

-linux/arm64/update_vcpkg_libs.sh
+linux/update_vcpkg_libs.sh $TRIPLET


Quote the variable to prevent word splitting: linux/update_vcpkg_libs.sh \"$TRIPLET\"

Suggested change

linux/update_vcpkg_libs.sh $TRIPLET

linux/update_vcpkg_libs.sh "$TRIPLET"

Copilot · 2025-10-06T02:22:22Z

linux/arm64/ci_configure_apps.sh

+export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET"

-linux/arm64/update_vcpkg_apps.sh
+linux/update_vcpkg_apps.sh $TRIPLET


Quote the variable to prevent word splitting: linux/update_vcpkg_apps.sh \"$TRIPLET\"

Suggested change

linux/update_vcpkg_apps.sh $TRIPLET

linux/update_vcpkg_apps.sh "$TRIPLET"

Copilot · 2025-10-06T02:22:22Z

linux/arm64/ci_configure_manager.sh

+export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET"
+export PKG_CONFIG_PATH=$VCPKG_DIR/lib/pkgconfig/
+
+linux/update_vcpkg_manager.sh $TRIPLET


Quote the variable to prevent word splitting: linux/update_vcpkg_manager.sh \"$TRIPLET\"

Suggested change

linux/update_vcpkg_manager.sh $TRIPLET

linux/update_vcpkg_manager.sh "$TRIPLET"

Copilot · 2025-10-06T02:22:23Z

linux/arm64/ci_configure_client.sh

+VCPKG_ROOT="$BUILD_DIR/vcpkg"
+export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET"
+
+linux/update_vcpkg_client.sh $TRIPLET


Quote the variable to prevent word splitting: linux/update_vcpkg_client.sh \"$TRIPLET\"

Suggested change

linux/update_vcpkg_client.sh $TRIPLET

linux/update_vcpkg_client.sh "$TRIPLET"

Copilot

Pull Request Overview

Copilot reviewed 41 out of 41 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T18:29:45Z

linux/update_vcpkg_libs.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use more robust parameter checking. The construct [ ! -z "$1" ] should be [ -n "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot · 2025-10-06T18:29:45Z

linux/update_vcpkg_client.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use more robust parameter checking. The construct [ ! -z "$1" ] should be [ -n "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot · 2025-10-06T18:29:46Z

linux/update_vcpkg_apps.sh

 fi

+TRIPLET="x64-linux"
+if [ ! -z "$1" ]; then


Use more robust parameter checking. The construct [ ! -z "$1" ] should be [ -n "$1" ] for better readability and POSIX compliance.

Suggested change

if [ ! -z "$1" ]; then

if [ -n "$1" ]; then

Copilot

Pull Request Overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 9 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

.github/workflows/rpmrepo/repo_update.sh

Copilot · 2025-10-10T16:30:17Z

.github/workflows/debrepo/repo_update.sh

+    prefixes=$(echo "$packets"| cut -d '_' -f 1 | sort -n | uniq)
+    suffixes=$(echo "$packets"| cut -d '_' -f 3- | sort -V | uniq)
+    for prefix in $prefixes; do
+        echo $prefix
+        for suffix in $suffixes; do
+            echo "  $suffix"
+            matched_packets=$(echo "$packets" | grep "^${prefix}_.*_${suffix}$")
+            echo "$matched_packets" | tail -n 1 | while IFS= read -r packet; do
+                echo "      Adding: $packet"
+                aptly -config=$CONF_FILE repo remove boinc-$TYPE $packet
+                exit_on_fail "Failed to remove the package"


In the stable branch you (a) use packets instead of alpha_packets, so the selection is empty, and (b) call repo remove instead of repo import. This prevents promoting the latest alpha packages into the stable repo. Replace packets with alpha_packets and use aptly ... repo import boinc-alpha-mirror boinc-$TYPE "$packet".

Suggested change

prefixes=$(echo "$packets"| cut -d '_' -f 1 | sort -n | uniq)

suffixes=$(echo "$packets"| cut -d '_' -f 3- | sort -V | uniq)

for prefix in $prefixes; do

echo $prefix

for suffix in $suffixes; do

echo " $suffix"

matched_packets=$(echo "$packets" | grep "^${prefix}_.*_${suffix}$")

echo "$matched_packets" | tail -n 1 | while IFS= read -r packet; do

echo " Adding: $packet"

aptly -config=$CONF_FILE repo remove boinc-$TYPE $packet

exit_on_fail "Failed to remove the package"

prefixes=$(echo "$alpha_packets"| cut -d '_' -f 1 | sort -n | uniq)

suffixes=$(echo "$alpha_packets"| cut -d '_' -f 3- | sort -V | uniq)

for prefix in $prefixes; do

echo $prefix

for suffix in $suffixes; do

echo " $suffix"

matched_packets=$(echo "$alpha_packets" | grep "^${prefix}_.*_${suffix}$")

echo "$matched_packets" | tail -n 1 | while IFS= read -r packet; do

echo " Importing: $packet"

aptly -config=$CONF_FILE repo import boinc-alpha-mirror boinc-$TYPE "$packet"

exit_on_fail "Failed to import the package"

Copilot · 2025-10-10T16:30:18Z

3rdParty/vcpkg_ports/triplets/ci/arm64-linux-release.cmake

+include(${VCPKG_ROOT}/triplets/community/arm64-linux-release.cmake)
+


The included upstream triplet path arm64-linux-release.cmake is likely incorrect; vcpkg provides arm64-linux.cmake in community triplets. Include arm64-linux.cmake and explicitly set VCPKG_BUILD_TYPE release (as done for x64) to ensure single-config builds.

Suggested change

include(${VCPKG_ROOT}/triplets/community/arm64-linux-release.cmake)

include(${VCPKG_ROOT}/triplets/community/arm64-linux.cmake)

set(VCPKG_BUILD_TYPE release)

.github/workflows/linux-package.yml

.github/workflows/linux.yml

Copilot · 2025-10-10T16:30:19Z

.github/workflows/linux-package.yml

+          RELEASE_TYPE=nightly # temporary for testing
+          echo "RELEASE_TYPE=${RELEASE_TYPE}" >> $GITHUB_ENV
          echo "SKIP_RUN=1" >> $GITHUB_ENV

      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+        #if: ${{ success() && env.SKIP_RUN == 0 }}
        with:
          fetch-depth: 2

      - name: DNF Preparation
        id: dnf-prep
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+        #if: ${{ success() && env.SKIP_RUN == 0 }}
        run: |
          sudo echo "max_parallel_downloads=10" >> /etc/dnf/dnf.conf
          sudo echo "fastestmirror=True" >> /etc/dnf/dnf.conf
          sudo dnf install -y wget rpm rpm-build rpm-sign expect createrepo_c dnf-utils jq p7zip-plugins

      - name: Setup GPG keys
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+        #if: ${{ success() && env.SKIP_RUN == 0 }}


The gating conditions for repo publishing steps are commented out and RELEASE_TYPE is force-set to nightly; this risks running publishing logic unexpectedly (including on forks). Restore the if: guards and remove the forced override to keep release/publish actions properly gated.

Copilot · 2025-10-10T16:30:19Z

.github/workflows/linux-package.yml

      - name: DNF Preparation
        id: dnf-prep
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+        #if: ${{ success() && env.SKIP_RUN == 0 }}


The gating conditions for repo publishing steps are commented out and RELEASE_TYPE is force-set to nightly; this risks running publishing logic unexpectedly (including on forks). Restore the if: guards and remove the forced override to keep release/publish actions properly gated.

Copilot · 2025-10-10T16:30:19Z

linux/arm64/ci_configure_apps.sh

+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"
 export _libcurl_pc="$VCPKG_DIR/lib/pkgconfig/libcurl.pc"
 export PKG_CONFIG_PATH=$VCPKG_DIR/lib/pkgconfig/
 export X_EXTRA_LIBS="-I$VCPKG_DIR/include $(pkg-config --libs freeglut)"


X_EXTRA_LIBS should only contain linker flags; include paths belong in CPPFLAGS. Move -I$VCPKG_DIR/include into CPPFLAGS to avoid passing non-library flags via LIBS and to improve configure-time detection.

Suggested change

export X_EXTRA_LIBS="-I$VCPKG_DIR/include $(pkg-config --libs freeglut)"

export X_EXTRA_LIBS="$(pkg-config --libs freeglut)"

Copilot · 2025-10-10T16:30:19Z

3rdParty/vcpkg_ports/ports/libx11/vcpkg.json

+    {
+      "name": "libx11",
+      "host": true
+    },
+    {


Declaring a host dependency on the same port (libx11) can create a self-dependency loop in vcpkg’s resolver. Consider moving build tools to a separate feature or using manual-tools from a bootstrap step without expressing a self host dependency.

Suggested change

{

"name": "libx11",

"host": true

},

{

{

Copilot

Pull Request Overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 10 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

.github/workflows/linux-package.yml

Copilot · 2025-10-10T23:04:32Z

linux/arm64/ci_configure_manager.sh

+export CFLAGS="-march=armv8-a -O3"
+export CXXFLAGS="-march=armv8-a -O3 -std=c++11"
+export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/"
+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"


-march is a compile flag and should be set in CFLAGS/CXXFLAGS, not LDFLAGS. Drop -march from LDFLAGS to avoid passing an unsupported option to the linker.

Suggested change

export LDFLAGS="-march=armv8-a -static-libstdc++ -s"

export LDFLAGS="-static-libstdc++ -s"

Copilot · 2025-10-10T23:04:32Z

linux/arm64/ci_configure_libs.sh

+export CFLAGS="-march=armv8-a -O3"
+export CXXFLAGS="-march=armv8-a -O3 -std=c++11"
+export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/"
+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"


-march belongs in CFLAGS/CXXFLAGS, not LDFLAGS. Remove -march from LDFLAGS to prevent linker warnings/errors.

Suggested change

export LDFLAGS="-march=armv8-a -static-libstdc++ -s"

export LDFLAGS="-static-libstdc++ -s"

Copilot · 2025-10-10T23:04:32Z

3rdParty/vcpkg_ports/ports/gtk3/vcpkg.json

+  "port-version": 1,
+  "description": "Portable library for creating graphical user interfaces.",
+  "homepage": "https://www.gtk.org/",
+  "license": null,


vcpkg manifest license must be a string or omitted; null is not a valid value and will fail schema validation. Either remove the license field or set it to the correct SPDX identifier (e.g., "LGPL-2.0-or-later").

Suggested change

"license": null,

Copilot · 2025-10-10T23:04:33Z

3rdParty/vcpkg_ports/ports/at-spi2-core/vcpkg.json

+  "port-version": 3,
+  "description": "Base DBus XML interfaces for accessibility, the accessibility registry daemon, and atspi library.",
+  "homepage": "https://www.gtk.org/",
+  "license": null,


The license field should not be null in vcpkg manifests. Remove the field or provide the correct SPDX identifier (e.g., "LGPL-2.1-or-later").

Suggested change

"license": null,

"license": "LGPL-2.1-or-later",

Copilot · 2025-10-10T23:04:33Z

3rdParty/vcpkg_ports/ports/libx11/vcpkg.json

+    "xcb",
+    "xproto",


Dependency names don't match vcpkg port names; use "libxcb" instead of "xcb" and "xorgproto" instead of "xproto" to resolve dependencies correctly.

Suggested change

"xcb",

"xproto",

"libxcb",

"xorgproto",

Copilot · 2025-10-10T23:04:33Z

3rdParty/vcpkg_ports/ports/libx11/portfile.cmake

+    find_program(XLSTPROC NAMES "xsltproc${VCPKG_HOST_EXECUTABLE_SUFFIX}" PATHS "${CURRENT_HOST_INSTALLED_DIR}/tools/libxslt" PATH_SUFFIXES "bin")
+endif()
+if(NOT XLSTPROC)
+    message(FATAL_ERROR "${PORT} requires xlstproc for the host system. Please install libxslt within vcpkg or your system package manager!")


Typo in the error message: "xlstproc" should be "xsltproc".

Suggested change

message(FATAL_ERROR "${PORT} requires xlstproc for the host system. Please install libxslt within vcpkg or your system package manager!")

message(FATAL_ERROR "${PORT} requires xsltproc for the host system. Please install libxslt within vcpkg or your system package manager!")

Copilot · 2025-10-10T23:04:34Z

3rdParty/vcpkg_ports/ports/libx11/vcxserver.patch

+ 	int len;
+
+ 	(void) GetHomeDir (fname, (int) (PATH_MAX - strlen (slashDotXdefaultsDash) - 1));
+    diff --git a/src/SetLocale.c b/src/SetLocale.c


The "diff --git" line is indented with spaces; patch application tools expect "diff --git" to start at column 0. Remove the leading spaces to ensure the patch applies cleanly.

Suggested change

diff --git a/src/SetLocale.c b/src/SetLocale.c

diff --git a/src/SetLocale.c b/src/SetLocale.c

Copilot · 2025-10-10T23:04:34Z

.github/workflows/linux-package.yml


      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+        #if: ${{ success() && env.SKIP_RUN == 0 }}


The conditional if is commented out; this step will now run unconditionally, ignoring SKIP_RUN and RELEASE_TYPE gating. Restore the if condition to keep the workflow logic intact.

Suggested change

#if: ${{ success() && env.SKIP_RUN == 0 }}

if: ${{ success() && env.SKIP_RUN == 0 }}

Copilot

Pull Request Overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T00:57:16Z

.github/workflows/rpmrepo/repo_update.sh

+            matched_packets=$(echo "$packets" | grep "^${prefix}-.*\.${suffix}.rpm$")
+            echo "$matched_packets" | tail -n 1 | while IFS= read -r packet; do
+			echo "Copy: $packet"
 			cp $value $CWD/mirror/


The variable used for copy is incorrect; cp references $value which is undefined in this scope. Use $packet to copy the selected RPM.

Suggested change

cp $value $CWD/mirror/

cp $packet $CWD/mirror/

Copilot · 2025-10-11T00:57:16Z

.github/workflows/debrepo/repo_update.sh

+                aptly -config=$CONF_FILE repo remove boinc-$TYPE $packet
+                exit_on_fail "Failed to remove the package"


This block is intended to add the latest alpha package to the stable repo, but it removes it instead. Replace repo remove with repo import boinc-alpha-mirror boinc-$TYPE "$packet" to import the latest package from the alpha mirror.

Suggested change

aptly -config=$CONF_FILE repo remove boinc-$TYPE $packet

exit_on_fail "Failed to remove the package"

aptly -config=$CONF_FILE repo import boinc-alpha-mirror boinc-$TYPE "$packet"

exit_on_fail "Failed to import the package"

Copilot · 2025-10-11T00:57:16Z

linux/arm64/ci_configure_client.sh

+export CFLAGS="-march=armv8-a -O3"
+export CXXFLAGS="-march=armv8-a -O3 -std=c++11"
+export CPPFLAGS="-I$VCPKG_DIR/include"
+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"


-march is a compile-time option and should be set in CFLAGS/CXXFLAGS, not LDFLAGS; remove -march=armv8-a from LDFLAGS to avoid passing it to the linker.

Suggested change

export LDFLAGS="-march=armv8-a -static-libstdc++ -s"

export LDFLAGS="-static-libstdc++ -s"

Copilot · 2025-10-11T00:57:17Z

linux/arm64/ci_configure_manager.sh

+export CFLAGS="-march=armv8-a -O3"
+export CXXFLAGS="-march=armv8-a -O3 -std=c++11"
+export CPPFLAGS="-I$VCPKG_DIR/include"
+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"


Remove -march=armv8-a from LDFLAGS; it is a compiler flag and should remain only in CFLAGS/CXXFLAGS.

Suggested change

export LDFLAGS="-march=armv8-a -static-libstdc++ -s"

export LDFLAGS="-static-libstdc++ -s"

Copilot · 2025-10-11T00:57:17Z

.github/workflows/linux-package.yml

+          RELEASE_TYPE=nightly # for debug purposes
          echo "SKIP_RUN=1" >> $GITHUB_ENV
+          echo "RELEASE_TYPE=${RELEASE_TYPE}" >> $GITHUB_ENV

      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+#        if: ${{ success() && env.SKIP_RUN == 0 }}
        with:
          fetch-depth: 2

      - name: Install dependencies
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+#        if: ${{ success() && env.SKIP_RUN == 0 }}
        run: |
          sudo apt-get update -qq
          sudo apt-get install -y aptly gnupg2 gpgv

      - name: Setup GPG keys
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+#        if: ${{ success() && env.SKIP_RUN == 0 }}
        run: |
          echo "${{ env.REPO_PRIV_KEY }}" > ${{ github.workspace }}/boinc.priv.key
          echo "${{ env.REPO_KEY }}" > ${{ github.workspace }}/boinc.pub.key
          cp "${{ github.workspace }}/boinc.pub.key" "${{ github.workspace }}/${{ env.PUBKEY }}"

-      - name: Download client
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+      - name: Download client arm64
+#        if: ${{ success() && env.SKIP_RUN == 0 }}
        uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0
        with:
-          name: linux-package_client_${{ matrix.os }}_${{ github.event.pull_request.head.sha }}
+          name: linux-package_client_arm64_${{ matrix.os }}_${{ github.event.pull_request.head.sha }}

-      - name: Download manager
-        if: ${{ success() && env.SKIP_RUN == 0 }}
+      - name: Download client amd64
+#        if: ${{ success() && env.SKIP_RUN == 0 }}


Debug changes force RELEASE_TYPE=nightly and comment out step conditions, causing repository update steps to run unconditionally; revert to guarded conditions (if:) and remove the hard-coded RELEASE_TYPE before merging.

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/rpmrepo/repo_update.sh:1

The loop reads each package into the variable packet, but the copy uses an undefined variable value. Replace value with packet to actually copy the selected file and fix the error message accordingly.

#!/bin/bash

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T02:20:07Z

linux/arm64/ci_configure_manager.sh

+export CFLAGS="-march=armv8-a -O3"
+export CXXFLAGS="-march=armv8-a -O3 -std=c++11"
+export CPPFLAGS="-I$VCPKG_DIR/include"
+export LDFLAGS="-march=armv8-a -static-libstdc++ -s"


-march=armv8-a is a compile-time flag and already present in CFLAGS/CXXFLAGS; passing it in LDFLAGS is unnecessary and can cause toolchain warnings. Recommend removing -march=armv8-a from LDFLAGS to keep compiler and linker flags separated.

Suggested change

export LDFLAGS="-march=armv8-a -static-libstdc++ -s"

export LDFLAGS="-static-libstdc++ -s"

AenBleidd force-pushed the vko_improve_linux_package_build branch 6 times, most recently from 7333340 to 00926d9 Compare October 3, 2025 05:10

Copilot AI review requested due to automatic review settings October 3, 2025 14:33

AenBleidd force-pushed the vko_improve_linux_package_build branch from 00926d9 to aa727f5 Compare October 3, 2025 14:33

Copilot AI reviewed Oct 3, 2025

View reviewed changes

linux/update_vcpkg_libs.sh Outdated Show resolved Hide resolved

linux/update_vcpkg_client.sh Outdated Show resolved Hide resolved

linux/update_vcpkg_apps.sh Outdated Show resolved Hide resolved

linux/arm64/ci_configure_apps.sh Outdated Show resolved Hide resolved

AenBleidd force-pushed the vko_improve_linux_package_build branch from aa727f5 to 84e107f Compare October 3, 2025 15:25

Copilot AI review requested due to automatic review settings October 3, 2025 15:49

AenBleidd force-pushed the vko_improve_linux_package_build branch from 84e107f to 490fb55 Compare October 3, 2025 15:49

Copilot AI reviewed Oct 3, 2025

View reviewed changes

linux/arm64/ci_configure_apps.sh Outdated Show resolved Hide resolved

linux/arm64/ci_configure_client.sh Outdated Show resolved Hide resolved

linux/arm64/ci_configure_manager.sh Outdated Show resolved Hide resolved

linux/arm64/ci_configure_libs.sh Outdated Show resolved Hide resolved

AenBleidd force-pushed the vko_improve_linux_package_build branch 2 times, most recently from 7dbc8c2 to 9023250 Compare October 3, 2025 17:11

Copilot AI review requested due to automatic review settings October 3, 2025 17:11

Copilot AI reviewed Oct 3, 2025

View reviewed changes

AenBleidd mentioned this pull request Oct 5, 2025

cairo[x11]: fix crossbuild. microsoft/vcpkg#47650

Merged

7 tasks

AenBleidd force-pushed the vko_improve_linux_package_build branch from 9023250 to c767270 Compare October 5, 2025 16:00

Copilot AI review requested due to automatic review settings October 5, 2025 16:35

AenBleidd force-pushed the vko_improve_linux_package_build branch from c767270 to 7368265 Compare October 5, 2025 16:35

Copilot AI reviewed Oct 5, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch from 7368265 to 690f31b Compare October 5, 2025 18:38

Copilot AI review requested due to automatic review settings October 6, 2025 02:21

AenBleidd force-pushed the vko_improve_linux_package_build branch from 690f31b to cdd80b6 Compare October 6, 2025 02:21

Copilot AI reviewed Oct 6, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch from cdd80b6 to efa2929 Compare October 6, 2025 03:18

Copilot AI review requested due to automatic review settings October 6, 2025 18:28

AenBleidd force-pushed the vko_improve_linux_package_build branch from efa2929 to a3de1a9 Compare October 6, 2025 18:28

Copilot AI reviewed Oct 6, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch from 675da6e to 7f99364 Compare October 8, 2025 01:32

Copilot AI review requested due to automatic review settings October 8, 2025 01:32

Copilot AI reviewed Oct 8, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch 2 times, most recently from a8292aa to 9695463 Compare October 10, 2025 16:26

Copilot AI review requested due to automatic review settings October 10, 2025 16:26

Copilot AI reviewed Oct 10, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch 2 times, most recently from 342ddfc to 2427523 Compare October 10, 2025 23:00

Copilot AI review requested due to automatic review settings October 10, 2025 23:00

Copilot AI reviewed Oct 10, 2025

View reviewed changes

AenBleidd force-pushed the vko_improve_linux_package_build branch from 2427523 to 1ee8fdf Compare October 10, 2025 23:57

Copilot AI review requested due to automatic review settings October 11, 2025 00:52

AenBleidd force-pushed the vko_improve_linux_package_build branch from 1ee8fdf to e8cc7b5 Compare October 11, 2025 00:52

Copilot AI reviewed Oct 11, 2025

View reviewed changes

[ci][linux] build client and manager for arm64

b6436bf

Signed-off-by: Vitalii Koshura <[email protected]>

AenBleidd force-pushed the vko_improve_linux_package_build branch from e8cc7b5 to b6436bf Compare October 11, 2025 01:21

AenBleidd added PR: Enhancement C: Build System OS: Linux C: Installer labels Oct 11, 2025

AenBleidd added this to Client/Manager Oct 11, 2025

github-project-automation bot moved this to In progress in Client/Manager Oct 11, 2025

AenBleidd added this to the Client/Manager 8.2.6 milestone Oct 11, 2025

AenBleidd marked this pull request as ready for review October 11, 2025 02:18

Copilot AI review requested due to automatic review settings October 11, 2025 02:18

Copilot AI reviewed Oct 11, 2025

View reviewed changes

AenBleidd merged commit 143d4a5 into master Oct 11, 2025
227 of 228 checks passed

AenBleidd deleted the vko_improve_linux_package_build branch October 11, 2025 02:21

github-project-automation bot moved this from In progress to Merged in Client/Manager Oct 11, 2025

	linux/update_vcpkg_manager.sh $TRIPLET
	linux/update_vcpkg_libs.sh $TRIPLET

	linux/update_vcpkg_libs.sh $TRIPLET
	linux/update_vcpkg_libs.sh "$TRIPLET"

	linux/update_vcpkg_apps.sh $TRIPLET
	linux/update_vcpkg_apps.sh "$TRIPLET"

	linux/update_vcpkg_manager.sh $TRIPLET
	linux/update_vcpkg_manager.sh "$TRIPLET"

	linux/update_vcpkg_client.sh $TRIPLET
	linux/update_vcpkg_client.sh "$TRIPLET"

		include(${VCPKG_ROOT}/triplets/community/arm64-linux-release.cmake)

	include(${VCPKG_ROOT}/triplets/community/arm64-linux-release.cmake)
	include(${VCPKG_ROOT}/triplets/community/arm64-linux.cmake)
	set(VCPKG_BUILD_TYPE release)

	export X_EXTRA_LIBS="-I$VCPKG_DIR/include $(pkg-config --libs freeglut)"
	export X_EXTRA_LIBS="$(pkg-config --libs freeglut)"

	export LDFLAGS="-march=armv8-a -static-libstdc++ -s"
	export LDFLAGS="-static-libstdc++ -s"

-    "xcb",
-    "xproto",
+    "libxcb",
+    "xorgproto",

	message(FATAL_ERROR "${PORT} requires xlstproc for the host system. Please install libxslt within vcpkg or your system package manager!")
	message(FATAL_ERROR "${PORT} requires xsltproc for the host system. Please install libxslt within vcpkg or your system package manager!")

	diff --git a/src/SetLocale.c b/src/SetLocale.c
	diff --git a/src/SetLocale.c b/src/SetLocale.c

	#if: ${{ success() && env.SKIP_RUN == 0 }}
	if: ${{ success() && env.SKIP_RUN == 0 }}

		aptly -config=$CONF_FILE repo remove boinc-$TYPE $packet
		exit_on_fail "Failed to remove the package"

[ci][linux] build client and manager for arm64 #6587

[ci][linux] build client and manager for arm64 #6587

Uh oh!

Conversation

AenBleidd commented Oct 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment