Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is mainstream SDK still against the idea proposed in this library ? #29

Closed
allan-simon opened this issue Aug 23, 2022 · 5 comments
Closed

Comments

@allan-simon
Copy link

As per this PR getsentry/sentry-php#1199 it seems to contradict with the reason given in What are the differences with the official Monolog Sentry handler?

@B-Galati
Copy link
Owner

Haha thank you for notifying! I was not aware of it. They may have changed their mind then, which is great!

IIRC, several PR try to add a Monolog breadcrumb handler back to the SDK. Because, yes the SDK was supporting breadcrumbs back in the day: https://github.com/getsentry/sentry-php/blob/1.x/lib/Raven/Breadcrumbs/MonologHandler.php.

This lib could be deprecated once the SDK integrated the handler 👍

@allan-simon
Copy link
Author

awesome !

@Wirone
Copy link
Contributor

Wirone commented Sep 21, 2022

What a timing they have 🙈 After so much work you did in #25 recently, Sentry introduces built-in support for Monolog breadcrumbs 😅

@B-Galati
Copy link
Owner

That's cool! I have to check how it works before deprecating mine though 👍

Don't have time these days 🙈

@B-Galati
Copy link
Owner

So I did some tests and the new Handler does not do the same job.

I added more info in the FAQ: basically the new handler is made to work with default integrations with error handlers, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants