-
Notifications
You must be signed in to change notification settings - Fork 65
Closed
2 / 22 of 2 issues completed
Copy link
Labels
breaking-changeA change that might cause specs or code to breakA change that might cause specs or code to breakepiclib:azure-resource-managerIssues for @azure-tools/typespec-azure-core libraryIssues for @azure-tools/typespec-azure-core library
Milestone
Description
Here is some background for these two sets of decorators for flattening purpose.
@conditionalClientFlattenand its config arm-resource-flattening in Azure.ResourceManager@flattenPropertyin TCGC
Previously,
- Swagger emitter only emits
@conditionalClientFlatten. It doesn't emit@flattenPropertybecause@flattenPropertyis only allowed inclient.tsp - TCGC emits
@flattenPropertyand@conditionalClientFlatten.
Therefore we need both of them.
Now,
- According to Two resources with one properties flattens while the other not #1931,
@flattenPropertyis agreed to be put intomain.tsp, so swagger emitter can emit it. See this. - TCGC emits
@flattenProperty.
Therefore @flattenProperty suffices for both scenarios.
Considering these two decorators are so confusing that we always take several hours/days to make people understand, and even ourselves cannot understand it easily, it seems we could remove @conditionalClientFlatten and its config arm-resource-flattening to improve the usability.
Sub-issues
Metadata
Metadata
Assignees
Labels
breaking-changeA change that might cause specs or code to breakA change that might cause specs or code to breakepiclib:azure-resource-managerIssues for @azure-tools/typespec-azure-core libraryIssues for @azure-tools/typespec-azure-core library