Skip to content

Commit a19d183

Browse files
committed
Fix signature and unit test of _check_timeout
1 parent 7bdcb8e commit a19d183

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

hpc_cluster_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def check_fqdn_collision(self, fqdn):
173173
return False
174174

175175
def _check_timeout(self, now=None):
176-
# type: (datetime) -> ([SlaveInfo], [SlaveInfo], [SlaveInfo])
176+
# type: (datetime) -> ([SlaveInfo], [SlaveInfo])
177177
# TODO: Check configuring timeout
178178
if now is None:
179179
now = datetime.now(pytz.utc)

hpc_cluster_manger_unittest.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -191,21 +191,21 @@ def test_check_node_idle_idle_after_remove(self, mock_restc):
191191
def test_provisioning_time_out_negative(self, mock_restc):
192192
clusmgr = HpcClusterManager(mock_restc, provisioning_timeout=TENMINUTES)
193193
clusmgr.add_slaveinfo(HOST1HOSTNAME, HOST1AGENTID, HOST1TASKID1, 1, UTCNOW)
194-
res, _, _ = clusmgr._check_timeout(UTCNOW + TENMINUTES - ONESEC)
194+
res, _ = clusmgr._check_timeout(UTCNOW + TENMINUTES - ONESEC)
195195
self.assertFalse(res)
196196

197197
@patch("hpc_cluster_manager.HpcRestClient", autospec=True)
198198
def test_provisioning_time_out_positive(self, mock_restc):
199199
clusmgr = HpcClusterManager(mock_restc, provisioning_timeout=TENMINUTES)
200200
clusmgr.add_slaveinfo(HOST1HOSTNAME, HOST1AGENTID, HOST1TASKID1, 1, UTCNOW)
201-
res, _, _ = clusmgr._check_timeout(UTCNOW + TENMINUTES)
201+
res, _ = clusmgr._check_timeout(UTCNOW + TENMINUTES)
202202
self.assertTrue(res)
203203

204204
@patch("hpc_cluster_manager.HpcRestClient", autospec=True)
205205
def test_provisioning_time_out_positive2(self, mock_restc):
206206
clusmgr = HpcClusterManager(mock_restc)
207207
clusmgr.add_slaveinfo(HOST1HOSTNAME, HOST1AGENTID, HOST1TASKID1, 1, UTCNOW)
208-
res, _, _ = clusmgr._check_timeout()
208+
res, _ = clusmgr._check_timeout()
209209
self.assertTrue(res)
210210

211211
@patch("hpc_cluster_manager.HpcRestClient", autospec=True)

0 commit comments

Comments
 (0)