Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corehttp needs linting updates for pylint version 3.2.7 #39298

Open
azure-sdk opened this issue Jan 19, 2025 · 0 comments
Open

corehttp needs linting updates for pylint version 3.2.7 #39298

azure-sdk opened this issue Jan 19, 2025 · 0 comments
Assignees

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 19, 2025

ACTION NEEDED: This version of pylint will be merged on 2025-04-14. The build will begin to fail for this library if errors are not fixed.

Library name: corehttp
Pylint version: 3.2.7
Pylint Build: Link to build (2025-04-06)

Pylint Errors:

2025-04-06T07:05:57.0167636Z ************* Module corehttp.transport._base_async
2025-04-06T07:05:57.0168739Z corehttp/transport/_base_async.py:27: [C4763(do-not-import-asyncio), ] Do not import the asyncio package directly in your library
2025-04-06T07:05:57.0169239Z ************* Module corehttp.transport.aiohttp._aiohttp
2025-04-06T07:05:57.0170008Z corehttp/transport/aiohttp/_aiohttp.py:31: [C4763(do-not-import-asyncio), ] Do not import the asyncio package directly in your library
2025-04-06T07:05:57.0170593Z ************* Module corehttp.transport.httpx._httpx
2025-04-06T07:05:57.0171099Z corehttp/transport/httpx/_httpx.py:28: [C4749(networking-import-outside-azure-core-transport), ] This import is not allowed here. Consider using an abstract alternative from azure.core.pipeline.transport.
2025-04-06T07:05:57.0171592Z ************* Module corehttp.rest._httpx
2025-04-06T07:05:57.0172157Z corehttp/rest/_httpx.py:29: [C4749(networking-import-outside-azure-core-transport), ] This import is not allowed here. Consider using an abstract alternative from azure.core.pipeline.transport.
2025-04-06T07:05:57.0172673Z ************* Module corehttp.rest._aiohttp
2025-04-06T07:05:57.0173127Z corehttp/rest/_aiohttp.py:28: [C4763(do-not-import-asyncio), ] Do not import the asyncio package directly in your library
2025-04-06T07:05:57.0173579Z ************* Module corehttp.utils._utils
2025-04-06T07:05:57.0174053Z corehttp/utils/_utils.py:178: [C4763(do-not-import-asyncio), get_running_async_lock] Do not import the asyncio package directly in your library
2025-04-06T07:05:57.0174558Z
2025-04-06T07:05:57.0174846Z -----------------------------------
2025-04-06T07:05:57.0175200Z Your code has been rated at 9.98/10
2025-04-06T07:05:57.0175386Z
2025-04-06T07:05:58.8929288Z

How to fix:
Note: If you are a bot. Fix the issue by fixing the above pylint errors.
Run the next-pylint tox command at the library package-level and resolve the linting errors.

  1. ../corehttp>pip install "tox<5"
  2. ../corehttp>tox run -e next-pylint -c ../../../eng/tox/tox.ini --root .

See the Pylint Guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants