updating communication shared code to use the isodate instead of the … (#42085)

* udpating communication shared code to use the isodate instead of the date util

* fixing the tests

* fix the test failure

* Updated communications dependencies

* Local transport import statements

* Use fixed offsets instead of ZoneInfo to fix tests in all environments

* addressing the comments

* changing to zoneinfo as per the comments

* Revert "changing to zoneinfo as per the comments"

This reverts commit 3e2610d.

---------

Co-authored-by: antisch <[email protected]>
Co-authored-by: Cezara Mateiasi <[email protected]>

Author: 3 people

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_shared/token_exchange.py

@@ -8,7 +8,7 @@
 from typing import Any, List, Optional
 # pylint: disable=non-abstract-transport-import
 # pylint: disable=no-name-in-module
-from azure.core.pipeline.transport import RequestsTransport
+
 from azure.core.credentials import AccessToken
 from azure.core.pipeline import Pipeline, PipelineResponse
 from azure.core.pipeline.policies import BearerTokenCredentialPolicy
@@ -50,6 +50,9 @@ def _create_pipeline_from_options(self, pipeline_transport):
         policies = [auth_policy, entra_token_guard_policy, retry_policy]
         if pipeline_transport:
             return Pipeline(policies=policies, transport=pipeline_transport)
+
+        from azure.core.pipeline.transport import RequestsTransport
+
         return Pipeline(policies=policies, transport=RequestsTransport())
 
     def exchange_entra_token(self) -> AccessToken:

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_shared/token_exchange_async.py

@@ -8,7 +8,7 @@
 from typing import Any, Optional, List
 # pylint: disable=non-abstract-transport-import
 # pylint: disable=no-name-in-module
-from azure.core.pipeline.transport import AioHttpTransport
+
 from azure.core.credentials import AccessToken
 from azure.core.pipeline import AsyncPipeline, PipelineResponse
 from azure.core.pipeline.policies import AsyncBearerTokenCredentialPolicy
@@ -50,6 +50,9 @@ def _create_pipeline_from_options(self, pipeline_transport):
         policies = [auth_policy, entra_token_guard_policy, retry_policy]
         if pipeline_transport:
             return AsyncPipeline(policies=policies, transport=pipeline_transport)
+
+        from azure.core.pipeline.transport import AioHttpTransport
+
         return AsyncPipeline(policies=policies, transport=AioHttpTransport())
 
     async def exchange_entra_token(self) -> AccessToken:

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_shared/token_utils.py

@@ -8,7 +8,7 @@
 import json
 from datetime import datetime, timezone
 from typing import Tuple, Any, List, Optional
-from dateutil import parser as dateutil_parser  # type: ignore
+import isodate
 from azure.core.exceptions import HttpResponseError
 
 TEAMS_EXTENSION_SCOPE_PREFIX = "https://auth.msft.communication.azure.com/"
@@ -54,7 +54,7 @@ def determine_endpoint_and_api_version(scopes: Optional[List[str]]) -> Tuple[str
 def parse_expires_on(expires_on, response):
     if isinstance(expires_on, str):
         try:
-            expires_on_dt = dateutil_parser.parse(expires_on)
+            expires_on_dt = isodate.parse_datetime(expires_on)
             expires_on_epoch = int(expires_on_dt.timestamp())
             return expires_on_epoch
         except Exception as exc:
@@ -84,7 +84,7 @@ def is_acs_token_cache_valid(response_cache):
         content = response_cache.http_response.text()
         data = json.loads(content)
         expires_on = data["accessToken"]["expiresOn"]
-        expires_on_dt = dateutil_parser.parse(expires_on)
+        expires_on_dt = isodate.parse_datetime(expires_on)
         return datetime.now(timezone.utc) < expires_on_dt
     except (KeyError, ValueError, json.JSONDecodeError):
         raise ValueError(  # pylint: disable=W0707

sdk/communication/azure-communication-callautomation/dev_requirements.txt

@@ -5,4 +5,3 @@
 -e ../../servicebus/azure-servicebus
 ../../core/azure-core
 aiohttp>=3.0
-python-dateutil>=2.8.1

sdk/communication/azure-communication-callautomation/setup.py

@@ -43,11 +43,11 @@
         "Programming Language :: Python",
         "Programming Language :: Python :: 3 :: Only",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Programming Language :: Python :: 3.12",
+        "Programming Language :: Python :: 3.13",
         "License :: OSI Approved :: MIT License",
     ],
     zip_safe=False,
@@ -59,15 +59,15 @@
             "azure.communication",
         ]
     ),
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     include_package_data=True,
     package_data={
         "pytyped": ["py.typed"],
     },
     install_requires=[
-        "msrest>=0.7.1",
-        "azure-core>=1.29.5",
-        "typing-extensions>=4.3.0",
+        "isodate>=0.6.1",
+        "azure-core>=1.30.0",
+        "typing-extensions>=4.6.0",
     ],
     project_urls={
         "Bug Reports": "https://github.com/Azure/azure-sdk-for-python/issues",

sdk/communication/azure-communication-chat/azure/communication/chat/_shared/token_exchange.py

@@ -8,7 +8,7 @@
 from typing import Any, List, Optional
 # pylint: disable=non-abstract-transport-import
 # pylint: disable=no-name-in-module
-from azure.core.pipeline.transport import RequestsTransport
+
 from azure.core.credentials import AccessToken
 from azure.core.pipeline import Pipeline, PipelineResponse
 from azure.core.pipeline.policies import BearerTokenCredentialPolicy
@@ -50,6 +50,9 @@ def _create_pipeline_from_options(self, pipeline_transport):
         policies = [auth_policy, entra_token_guard_policy, retry_policy]
         if pipeline_transport:
             return Pipeline(policies=policies, transport=pipeline_transport)
+
+        from azure.core.pipeline.transport import RequestsTransport
+
         return Pipeline(policies=policies, transport=RequestsTransport())
 
     def exchange_entra_token(self) -> AccessToken:

sdk/communication/azure-communication-chat/azure/communication/chat/_shared/token_exchange_async.py

@@ -8,7 +8,7 @@
 from typing import Any, Optional, List
 # pylint: disable=non-abstract-transport-import
 # pylint: disable=no-name-in-module
-from azure.core.pipeline.transport import AioHttpTransport
+
 from azure.core.credentials import AccessToken
 from azure.core.pipeline import AsyncPipeline, PipelineResponse
 from azure.core.pipeline.policies import AsyncBearerTokenCredentialPolicy
@@ -50,6 +50,9 @@ def _create_pipeline_from_options(self, pipeline_transport):
         policies = [auth_policy, entra_token_guard_policy, retry_policy]
         if pipeline_transport:
             return AsyncPipeline(policies=policies, transport=pipeline_transport)
+
+        from azure.core.pipeline.transport import AioHttpTransport
+
         return AsyncPipeline(policies=policies, transport=AioHttpTransport())
 
     async def exchange_entra_token(self) -> AccessToken:

sdk/communication/azure-communication-chat/azure/communication/chat/_shared/token_utils.py

@@ -8,7 +8,7 @@
 import json
 from datetime import datetime, timezone
 from typing import Tuple, Any, List, Optional
-from dateutil import parser as dateutil_parser  # type: ignore
+import isodate
 from azure.core.exceptions import HttpResponseError
 
 TEAMS_EXTENSION_SCOPE_PREFIX = "https://auth.msft.communication.azure.com/"
@@ -54,7 +54,7 @@ def determine_endpoint_and_api_version(scopes: Optional[List[str]]) -> Tuple[str
 def parse_expires_on(expires_on, response):
     if isinstance(expires_on, str):
         try:
-            expires_on_dt = dateutil_parser.parse(expires_on)
+            expires_on_dt = isodate.parse_datetime(expires_on)
             expires_on_epoch = int(expires_on_dt.timestamp())
             return expires_on_epoch
         except Exception as exc:
@@ -84,7 +84,7 @@ def is_acs_token_cache_valid(response_cache):
         content = response_cache.http_response.text()
         data = json.loads(content)
         expires_on = data["accessToken"]["expiresOn"]
-        expires_on_dt = dateutil_parser.parse(expires_on)
+        expires_on_dt = isodate.parse_datetime(expires_on)
         return datetime.now(timezone.utc) < expires_on_dt
     except (KeyError, ValueError, json.JSONDecodeError):
         raise ValueError(  # pylint: disable=W0707

sdk/communication/azure-communication-chat/dev_requirements.txt

@@ -1,4 +1,3 @@
 -e ../../../tools/azure-sdk-tools
 -e ../azure-communication-identity
-aiohttp>=3.0
-python-dateutil>=2.8.1
+aiohttp>=3.0

sdk/communication/azure-communication-chat/setup.py

@@ -43,11 +43,11 @@
         "Programming Language :: Python",
         "Programming Language :: Python :: 3 :: Only",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Programming Language :: Python :: 3.12",
+        "Programming Language :: Python :: 3.13",
         "License :: OSI Approved :: MIT License",
     ],
     zip_safe=False,
@@ -59,7 +59,7 @@
             "azure.communication",
         ]
     ),
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     include_package_data=True,
     package_data={
         "pytyped": ["py.typed"],