Using new management plain generator for service connectedcache #53761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generated code for the Azure.ResourceManager.ConnectedCache SDK, primarily transitioning to a newer code generation pattern. The changes include property naming corrections (e.g., IPAddress → IpAddress), REST operations refactoring with new API signatures, and updates to serialization patterns.
Key changes:
- Property naming fixes for consistency (IPAddress/BgpAsnToIPAddressMapping → IpAddress/BgpAsnToIpAddressMapping)
- REST operations classes refactored with simplified signatures using
RequestContextandRequestContent - Serialization infrastructure updated to newer patterns with
_additionalBinaryDataProperties
Reviewed Changes
Copilot reviewed 3 out of 137 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Added emitter package configuration path |
| Sample_IspCacheNodeCollection.cs | Updated property names from IPAddress to IpAddress |
| Sample_EnterpriseMccCacheNodeCollection.cs | Updated property names from IPAddress to IpAddress |
| IspCustomersRestOperations.cs | Refactored to simpler class with RequestContext-based methods |
| IspCacheNodesRestOperations.cs | Deleted (replaced by IspCacheNodesOperationsRestOperations.cs) |
| IspCacheNodesOperationsRestOperations.cs | New REST operations class with updated patterns |
| EnterpriseMccCustomersRestOperations.cs | Refactored to simpler class with RequestContext-based methods |
| EnterpriseMccCacheNodesRestOperations.cs | Deleted (replaced by EnterpriseMccCacheNodesOperationsRestOperations.cs) |
| EnterpriseMccCacheNodesOperationsRestOperations.cs | New REST operations class with updated patterns |
| ProviderConstants.cs | Changed to partial class and added XML documentation |
| MccCustomerProperty.cs/.Serialization.cs | Updated serialization infrastructure |
| MccCustomerEntity.cs/.Serialization.cs | Updated property names and serialization patterns |
| MccCustomerAdditionalProperties.cs/.Serialization.cs | Updated property names and serialization patterns |
| MccCacheNodeTlsCertificate*.cs | Updated to newer serialization patterns and TrackedResourceData base |
| MccCacheNodeProxyUriConfiguration.cs | Updated serialization field naming |
| MccCacheNodeProxyRequired.cs | Added operator overloads and improved documentation |
haiyuazhang
force-pushed
the
haiyzhan/connectedcache
branch
from
06093f5 to
829befa
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
haiyuazhang
commented
Nov 11, 2025
| { | ||
| internal MccCacheNodeAutoUpdateHistoryProperties() { } | ||
| public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.ConnectedCache.Models.MccCacheNodeAutoUpdateInfo> AutoUpdateHistory { get { throw null; } } | ||
| public System.Collections.Generic.IList<Azure.ResourceManager.ConnectedCache.Models.MccCacheNodeAutoUpdateInfo> AutoUpdateHistory { get { throw null; } } |
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
in MTG, we only honor property's readonly, not the model's usage. If there is no breaking change, this is correct.
sdk/connectedcache/Azure.ResourceManager.ConnectedCache/src/Generated/IspCustomerCollection.cs
Outdated
Show resolved
Hide resolved
haiyuazhang
force-pushed
the
haiyzhan/connectedcache
branch
from
0a20b46 to
e75bf70
Compare
haiyuazhang
force-pushed
the
haiyzhan/connectedcache
branch
from
e75bf70 to
769d8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.