add IConfigManagerWithEvents

Author: BethanyZhou

src/Authentication.Abstractions/Authentication.Abstractions.csproj

@@ -54,7 +54,6 @@
 
   <ItemGroup>
     <None Include="..\..\LICENSE.txt" Link="LICENSE.txt" Pack="true" PackagePath="" />
-    <Folder Include="Models\" />
   </ItemGroup>
 
 </Project>

src/Authentication.Abstractions/Interfaces/IConfigManagerWithEvents.cs

@@ -0,0 +1,14 @@
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions.Models;
+using Microsoft.Azure.PowerShell.Common.Config;
+
+using System;
+
+namespace Microsoft.Azure.Commands.Common.Authentication.Config
+{
+    public interface IConfigManagerWithEvents: IConfigManager
+    {
+        event EventHandler<ConfigEventArgs> ConfigRead;
+        event EventHandler<ConfigEventArgs> ConfigUpdated;
+        event EventHandler<ConfigEventArgs> ConfigCleared;
+    }
+}

src/Authentication.Abstractions/Models/ConfigEventArgs .cs

@@ -0,0 +1,21 @@
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
+using System;
+using System.Collections.Generic;
+
+namespace Microsoft.Azure.Commands.Common.Authentication.Abstractions.Models
+{
+    public class ConfigEventArgs : EventArgs, IExtensibleModel
+    {
+        public string ConfigKey { get; }
+
+        public string ConfigValue { get; }
+
+        public IDictionary<string, string> ExtendedProperties { get; } = new Dictionary<string, string>();
+
+        public ConfigEventArgs(string configKey, string configValue)
+        {
+            ConfigKey = configKey;
+            ConfigValue = configValue;
+        }
+    }
+}

src/Authentication.Abstractions/Models/ConfigReadEventArgs.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Microsoft.Azure.Commands.Common.Authentication.Abstractions.Models
+{
+    public class ConfigReadEventArgs : ConfigEventArgs
+    {
+        public string ConfigTelemetryKey { get; }
+
+        public ConfigReadEventArgs(string configKey, string configValue) : this(configKey, configKey, configValue)
+        {
+        }
+
+        public ConfigReadEventArgs(string configKey, string configTelemetryKey, string configValue) : base(configKey, configValue)
+        {
+            ConfigTelemetryKey = configTelemetryKey;
+        }
+    }
+}

src/Common/AzurePSCmdlet.cs

@@ -14,6 +14,8 @@
 
 using Microsoft.Azure.Commands.Common.Authentication;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions.Models;
+using Microsoft.Azure.Commands.Common.Authentication.Config;
 using Microsoft.Azure.PowerShell.Common.Config;
 using Microsoft.Azure.PowerShell.Common.Share.Survey;
 using Microsoft.Azure.PowerShell.Common.UpgradeNotification;
@@ -522,6 +524,25 @@ protected void WriteSurvey()
             }
         }
 
+
+        private void AddTelemetryForConfig()
+        {
+            // attach config read event handler to add config telemetry
+            AzureSession.Instance.TryGetComponent<IConfigManager>(nameof(IConfigManager), out var configManager);
+            if (configManager is IConfigManagerWithEvents cm)
+            {
+                cm.ConfigRead += OnConfigReaded;
+            }            
+        }
+
+        private void OnConfigReaded(object sender, ConfigEventArgs args)
+        {
+            if (!_qosEvent.ConfigMetrics.ContainsKey(args.ConfigKey) && args is ConfigReadEventArgs readEventArgs)
+            {
+                _qosEvent.ConfigMetrics[readEventArgs.ConfigKey] = new ConfigMetrics(readEventArgs.ConfigTelemetryKey, readEventArgs.ConfigValue.ToString());
+            }
+        }
+
         protected new void ThrowTerminatingError(ErrorRecord errorRecord)
         {
             FlushDebugMessages();
@@ -546,7 +567,8 @@ protected void WriteSurvey()
             base.WriteObject(sendToPipeline, enumerateCollection);
         }
 
-        private void SanitizeOutput(object sendToPipeline)
+
+    private void SanitizeOutput(object sendToPipeline)
         {
             if (OutputSanitizer?.RequireSecretsDetection == true)
             {
@@ -772,6 +794,8 @@ protected virtual void InitializeQosEvent()
             }
 
             _qosEvent.SanitizerInfo = new SanitizerTelemetry(OutputSanitizer?.RequireSecretsDetection == true);
+
+            AddTelemetryForConfig();
         }
 
         private void RecordDebugMessages()