Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting status of instances does not support continuation token #319

Open
przemos opened this issue Feb 9, 2022 · 1 comment
Open

Getting status of instances does not support continuation token #319

przemos opened this issue Feb 9, 2022 · 1 comment
Labels
Enhancement New feature or request help wanted Extra attention is needed P2 Priority 2 item

Comments

@przemos
Copy link

przemos commented Feb 9, 2022

It seems that as much as C# version of the library supports continuation token while iterating over execution instances with History API, NodeJS does not. Instead, it tries to encapsulate iteration process by managing continuation token itself.
Unfortunately, as much as some people may consider it useful, in general, it is quite limiting. It is limiting for wrong reasons - it would be nice to keep the API on par with C# one as much as possible for consistency.

Imagine you have 100K executions. Do you really want to fill up your process' memory with 100K rows or let the user decide how the paging over will be implemented e.g. read 1000 rows, process them, dispose, then another 1000 rows, etc. ?

@ghost ghost added the Needs: Triage 🔍 label Feb 9, 2022
@przemos przemos changed the title Getting status of instances do not support continuation token Getting status of instances does not support continuation token Feb 9, 2022
@davidmrdavid davidmrdavid added help wanted Extra attention is needed P2 Priority 2 item and removed Needs: Triage 🔍 labels Feb 10, 2022
@davidmrdavid
Copy link
Collaborator

Thanks for the feature request, @przemos. Broadly speaking, I agree that we want to keep the NodeJS SDK as feature-complete as possible, as I'm doing some work behind the scenes to help us do that here and across the other Durable SDKs. I can't speak much about that publically at the moment, but I figured I'd hint at it since you mentioned that we want to keep the API on par with C# - which is one of our goals!

This does need some design though. Could you provide us with a few sample code snippets to exemplify what programming experience you'd expect for this feature? More concretely, what's an example syntax you'd use to manage the pagination logic as part of your user code. We can use that as a starting point for the design here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request help wanted Extra attention is needed P2 Priority 2 item
Projects
None yet
Development

No branches or pull requests

4 participants