Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add durable-specific serialization logic in the nodeJS worker #245

Open
davidmrdavid opened this issue Feb 19, 2021 · 0 comments
Open

Add durable-specific serialization logic in the nodeJS worker #245

davidmrdavid opened this issue Feb 19, 2021 · 0 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file P2 Priority 2 item
Milestone

Comments

@davidmrdavid
Copy link
Collaborator

davidmrdavid commented Feb 19, 2021

In this ticket, we learned that our string-serialization patch here has broken some function.json functionality for some of our users.

The patch listed above was a minor "hack" in hopes to avoid changing the nodejs-worker's serialization logic, which could impact all of the JS azure functions infrastructure, not just durable. So while making serialization changes in the worker is often discouraged, in this case, since the new error manifests in a function.json, there's no fix we can implement at the Durable-level to get around this: a solution needs to be implemented in the worker.

To minimize impact and legacy behaviour across JS Functions, we can write durable-bindings-specific serialization and de-serialization logic in the worker.

The relevant files to modify are listed below:

@ghost ghost added the Needs: Triage 🔍 label Feb 19, 2021
@davidmrdavid davidmrdavid changed the title Add durable-specific serialization logic in the nodeJS work Add durable-specific serialization logic in the nodeJS worker Feb 19, 2021
@davidmrdavid davidmrdavid self-assigned this Feb 19, 2021
@davidmrdavid davidmrdavid added bug Something isn't working dependencies Pull requests that update a dependency file P2 Priority 2 item and removed Needs: Triage 🔍 labels Feb 19, 2021
@davidmrdavid davidmrdavid added this to the 1.4.7 milestone Mar 9, 2021
@davidmrdavid davidmrdavid removed their assignment Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file P2 Priority 2 item
Projects
None yet
Development

No branches or pull requests

1 participant