Skip to content

Commit 7060465

Browse files
ellismgellismg
committed
templates: Address Bicep Lint Warnings
1 parent 6e16f37 commit 7060465

File tree

8 files changed

+17
-19
lines changed

8 files changed

+17
-19
lines changed

‎templates/common/infra/bicep/core/host/container-apps.bicep

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ module containerAppsEnvironment 'container-apps-environment.bicep' = {
2525

2626
module containerRegistry 'container-registry.bicep' = {
2727
name: '${name}-container-registry'
28+
#disable-next-line BCP036
2829
scope: !empty(containerRegistryResourceGroupName) ? resourceGroup(containerRegistryResourceGroupName) : resourceGroup()
2930
params: {
3031
name: containerRegistryName

‎templates/common/infra/bicep/core/monitor/applicationinsights-dashboard.bicep

+16
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
3434
]
3535
#disable-next-line BCP036
3636
type: 'Extension/AppInsightsExtension/PartType/AspNetOverviewPinnedPart'
37+
#disable-next-line BCP037
3738
asset: {
3839
idInputName: 'id'
3940
type: 'ApplicationInsights'
4041
}
42+
#disable-next-line BCP037
4143
defaultMenuItemId: 'overview'
4244
}
4345
}
@@ -65,10 +67,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
6567
]
6668
#disable-next-line BCP036
6769
type: 'Extension/AppInsightsExtension/PartType/ProactiveDetectionAsyncPart'
70+
#disable-next-line BCP037
6871
asset: {
6972
idInputName: 'ComponentId'
7073
type: 'ApplicationInsights'
7174
}
75+
#disable-next-line BCP037
7276
defaultMenuItemId: 'ProactiveDetection'
7377
}
7478
}
@@ -96,6 +100,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
96100
]
97101
#disable-next-line BCP036
98102
type: 'Extension/AppInsightsExtension/PartType/QuickPulseButtonSmallPart'
103+
#disable-next-line BCP037
99104
asset: {
100105
idInputName: 'ComponentId'
101106
type: 'ApplicationInsights'
@@ -137,6 +142,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
137142
]
138143
#disable-next-line BCP036
139144
type: 'Extension/AppInsightsExtension/PartType/AvailabilityNavButtonPart'
145+
#disable-next-line BCP037
140146
asset: {
141147
idInputName: 'ComponentId'
142148
type: 'ApplicationInsights'
@@ -178,6 +184,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
178184
]
179185
#disable-next-line BCP036
180186
type: 'Extension/AppInsightsExtension/PartType/AppMapButtonPart'
187+
#disable-next-line BCP037
181188
asset: {
182189
idInputName: 'ComponentId'
183190
type: 'ApplicationInsights'
@@ -236,6 +243,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
236243
]
237244
#disable-next-line BCP036
238245
type: 'Extension/AppInsightsExtension/PartType/UsageUsersOverviewPart'
246+
#disable-next-line BCP037
239247
asset: {
240248
idInputName: 'ComponentId'
241249
type: 'ApplicationInsights'
@@ -298,11 +306,14 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
298306
]
299307
#disable-next-line BCP036
300308
type: 'Extension/AppInsightsExtension/PartType/CuratedBladeFailuresPinnedPart'
309+
#disable-next-line BCP037
301310
isAdapter: true
311+
#disable-next-line BCP037
302312
asset: {
303313
idInputName: 'ResourceId'
304314
type: 'ApplicationInsights'
305315
}
316+
#disable-next-line BCP037
306317
defaultMenuItemId: 'failures'
307318
}
308319
}
@@ -362,11 +373,14 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
362373
]
363374
#disable-next-line BCP036
364375
type: 'Extension/AppInsightsExtension/PartType/CuratedBladePerformancePinnedPart'
376+
#disable-next-line BCP037
365377
isAdapter: true
378+
#disable-next-line BCP037
366379
asset: {
367380
idInputName: 'ResourceId'
368381
type: 'ApplicationInsights'
369382
}
383+
#disable-next-line BCP037
370384
defaultMenuItemId: 'performance'
371385
}
372386
}
@@ -453,10 +467,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
453467
]
454468
#disable-next-line BCP036
455469
type: 'Extension/AppInsightsExtension/PartType/MetricsExplorerBladePinnedPart'
470+
#disable-next-line BCP037
456471
asset: {
457472
idInputName: 'ComponentId'
458473
type: 'ApplicationInsights'
459474
}
475+
#disable-next-line BCP037
460476
defaultMenuItemId: 'browser'
461477
}
462478
}

‎templates/todo/projects/java-mongo-aca/.repo/bicep/infra/main.bicep

-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ param apimSku string = 'Consumption'
4040
@description('Id of the user or app to assign application roles')
4141
param principalId string = ''
4242

43-
@description('The base URL used by the web service for sending API requests')
44-
param webApiBaseUrl string = ''
45-
4643
var abbrs = loadJsonContent('../../../../../../common/infra/bicep/abbreviations.json')
4744
var resourceToken = toLower(uniqueString(subscription().id, environmentName, location))
4845
var tags = { 'azd-env-name': environmentName }

‎templates/todo/projects/java-mongo-aca/.repo/bicep/infra/main.parameters.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"webAppExists": {
1818
"value": "${SERVICE_WEB_RESOURCE_EXISTS=false}"
1919
},
20-
"webApiBaseUrl": {
21-
"value": "${REACT_APP_API_BASE_URL}"
22-
},
2320
"useAPIM": {
2421
"value": "${USE_APIM=false}"
2522
},

‎templates/todo/projects/nodejs-mongo-aca/.repo/bicep/infra/main.bicep

-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ param containerRegistryHostSuffix string = 'azurecr.io'
4040
@description('Id of the user or app to assign application roles')
4141
param principalId string = ''
4242

43-
@description('The base URL used by the web service for sending API requests')
44-
param webApiBaseUrl string = ''
45-
4643
var abbrs = loadJsonContent('../../../../../../common/infra/bicep/abbreviations.json')
4744
var resourceToken = toLower(uniqueString(subscription().id, environmentName, location))
4845
var tags = { 'azd-env-name': environmentName }

‎templates/todo/projects/nodejs-mongo-aca/.repo/bicep/infra/main.parameters.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"webAppExists": {
1818
"value": "${SERVICE_WEB_RESOURCE_EXISTS=false}"
1919
},
20-
"webApiBaseUrl": {
21-
"value": "${REACT_APP_API_BASE_URL}"
22-
},
2320
"useAPIM": {
2421
"value": "${USE_APIM=false}"
2522
},

‎templates/todo/projects/python-mongo-aca/.repo/bicep/infra/main.bicep

-4
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,9 @@ param apimSku string = 'Consumption'
3737
@description('Hostname suffix for container registry. Set when deploying to sovereign clouds')
3838
param containerRegistryHostSuffix string = 'azurecr.io'
3939

40-
4140
@description('Id of the user or app to assign application roles')
4241
param principalId string = ''
4342

44-
@description('The base URL used by the web service for sending API requests')
45-
param webApiBaseUrl string = ''
46-
4743
var abbrs = loadJsonContent('../../../../../../common/infra/bicep/abbreviations.json')
4844
var resourceToken = toLower(uniqueString(subscription().id, environmentName, location))
4945
var tags = { 'azd-env-name': environmentName }

‎templates/todo/projects/python-mongo-aca/.repo/bicep/infra/main.parameters.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"webAppExists": {
1818
"value": "${SERVICE_WEB_RESOURCE_EXISTS=false}"
1919
},
20-
"webApiBaseUrl": {
21-
"value": "${API_BASE_URL}"
22-
},
2320
"useAPIM": {
2421
"value": "${USE_APIM=false}"
2522
},

0 commit comments

Comments
 (0)