Skip to content

Commit 09679a1

Browse files
committed
Addresses PR feedback
1 parent 4726a3a commit 09679a1

File tree

7 files changed

+8
-30
lines changed

7 files changed

+8
-30
lines changed

Diff for: templates/common/infra/bicep/core/host/aks-automatic-cluster.bicep

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ param location string = resourceGroup().location
1212
param tags object = {}
1313

1414
@description('Kubernetes Version')
15-
param kubernetesVersion string
15+
param kubernetesVersion string = '1.28'
1616

1717
@description('The DNS prefix to associate with the AKS cluster')
1818
param dnsPrefix string = ''

Diff for: templates/common/infra/bicep/core/host/aks-managed-cluster.bicep

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ param location string = resourceGroup().location
1212
param tags object = {}
1313

1414
@description('Kubernetes Version')
15-
param kubernetesVersion string = '1.28.9'
15+
param kubernetesVersion string = '1.28'
1616

1717
@description('Whether RBAC is enabled for local accounts')
1818
param enableRbac bool = true

Diff for: templates/common/infra/bicep/core/host/aks.bicep

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ param principalId string = ''
101101
param principalType string = 'User'
102102

103103
@description('Kubernetes Version')
104-
param kubernetesVersion string = '1.28.9'
104+
param kubernetesVersion string = '1.28'
105105

106106
@description('The Tenant ID associated to the Azure Active Directory')
107107
param aadTenantId string = tenant().tenantId

Diff for: templates/todo/projects/nodejs-mongo-aks/.repo/bicep/azure.yaml

+3-11
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ services:
2121
prebuild:
2222
windows:
2323
shell: pwsh
24-
run: 'echo "VITE_API_BASE_URL=""$env:API_BASE_URL""" > .env.local ; echo "VITE_APPLICATIONINSIGHTS_CONNECTION_STRING=""$env:APPLICATIONINSIGHTS_CONNECTION_STRING""" >> .env.local'
24+
run: 'echo "VITE_API_BASE_URL=""$env:SERVICE_API_ENDPOINT_URL""" > .env.local ; echo "VITE_APPLICATIONINSIGHTS_CONNECTION_STRING=""$env:APPLICATIONINSIGHTS_CONNECTION_STRING""" >> .env.local'
2525
posix:
2626
shell: sh
27-
run: 'echo VITE_API_BASE_URL=\"$API_BASE_URL\" > .env.local && echo VITE_APPLICATIONINSIGHTS_CONNECTION_STRING=\"$APPLICATIONINSIGHTS_CONNECTION_STRING\" >> .env.local'
27+
run: 'echo VITE_API_BASE_URL=\"$SERVICE_API_ENDPOINT_URL\" > .env.local && echo VITE_APPLICATIONINSIGHTS_CONNECTION_STRING=\"$APPLICATIONINSIGHTS_CONNECTION_STRING\" >> .env.local'
2828
postbuild:
2929
windows:
3030
shell: pwsh
@@ -38,12 +38,4 @@ services:
3838
host: aks
3939
k8s:
4040
ingress:
41-
relativePath: api
42-
hooks:
43-
postdeploy:
44-
windows:
45-
shell: pwsh
46-
run: azd env set API_BASE_URL $env:SERVICE_API_ENDPOINT_URL
47-
posix:
48-
shell: sh
49-
run: azd env set API_BASE_URL ${SERVICE_API_ENDPOINT_URL}
41+
relativePath: api

Diff for: templates/todo/projects/nodejs-mongo-aks/src/web/manifests/config.tmpl.yaml

-6
This file was deleted.

Diff for: templates/todo/projects/nodejs-mongo-aks/src/web/manifests/deployment.tmpl.yaml

+1-9
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,4 @@ spec:
1717
image: {{.Env.SERVICE_WEB_IMAGE_NAME}}
1818
ports:
1919
- containerPort: 3000
20-
env:
21-
- name: VITE_API_BASE_URL
22-
value: /api
23-
- name: VITE_APPLICATIONINSIGHTS_CONNECTION_STRING
24-
valueFrom:
25-
configMapKeyRef:
26-
name: todo-web-config
27-
key: VITE_APPLICATIONINSIGHTS_CONNECTION_STRING
28-
optional: false
20+

Diff for: templates/todo/web/react-fluent/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "todo-vite-node-mongo-aca",
2+
"name": "todo-vite-node-mongo",
33
"private": true,
44
"version": "0.0.0",
55
"type": "module",

0 commit comments

Comments
 (0)