CNS Possibly Not Handling Error Correctly and Possibly Not Releasing IP Address

[MikeZappa87]

I have not observed this however while reading the code, I noticed this as a possible condition that may not release the ip address.

azure-container-networking/cns/fsnotify/fsnotify.go

Line 60 in a2a2ab8

file, err := os.Open(filepath)

If os.Open(..) returns an error, we log however continue. io.ReadAll(...) returns an invalid argument error and continues (but logs error). The .Close function handles the nil condition and continues.

podInterfaceID := string(data) is just an empty string and assuming what ever was supposed to happen on line

azure-container-networking/cns/fsnotify/fsnotify.go

Line 73 in a2a2ab8

if err := w.releaseIP(ctx, podInterfaceID, containerID); err != nil {

is not happening?

Note: I didn't do a full analysis however the function looks suspect.

[github-actions]

This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

[github-actions]

This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days