You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Contributers must sign the CLA. The CLA bot will post instructions to new contributors when their first PR is opened as a comment. To agree to the CLA, respond:
- Use a [forking workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow). [(How to fork)](https://help.github.com/articles/fork-a-repo/).
4
+
5
+
### Pull Requests
6
+
Do:
7
+
- Scope PRs to the smallest self-contained change possible.
8
+
- Open one PR per change (for example: a feature addition and a refactor of related code are separate changes warranting separate PRs).
9
+
- Use a descriptive title and description. Provide enough context that anyone familiar with the codebase can understand the purpose of the change and review it.
10
+
- Include a link to a related issue if applicable.
11
+
- Attach labels.
12
+
- Assign reviewers if the automated reviewer assignment is insufficient.
13
+
- Open PRs early as a draft and add the `WIP` label to get early feedback.
14
+
- Rebase from master when your branch/PR is out of date.
15
+
- Fix review feedback in individual commits with descriptive commit messages (and link these commits in the comments).
16
+
17
+
Do not:
18
+
- Link to private issue trackers or internal documents.
19
+
- Ask for final reviews unless CI is passing.
20
+
- Resolve reviewer comments yourself (allow the reviewer to do so once they are satisfied that their feedback is addressed).
21
+
- Close and open a new PR to address git conflicts or feedback (PRs are documentation. One PR per change).
0 commit comments