Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting ChatRequest name #20

Open
agoncal opened this issue Nov 29, 2024 · 4 comments
Open

Conflicting ChatRequest name #20

agoncal opened this issue Nov 29, 2024 · 4 comments
Assignees

Comments

@agoncal
Copy link
Contributor

agoncal commented Nov 29, 2024

In the workshop there is a ChatRequest class. But in the last LC4j versions there is now an experimental ChatRequest API too. And if you leave your IDE doing the auto-import, it imports the LC4j one. We should change the name of the API (and also the ChatResource....). Maybe ChatRagRequest or something like that

https://github.com/langchain4j/langchain4j/blob/main/langchain4j-core/src/main/java/dev/langchain4j/model/chat/request/ChatRequest.java

@jdubois
Copy link
Contributor

jdubois commented Nov 29, 2024

Yes we should refactor it to something meaningful for us, AssistantChatRequest?

@agoncal
Copy link
Contributor Author

agoncal commented Dec 2, 2024

Yes, we should rename all our classes so we don't have any conflict and the naming is consistent. What about having:

  • AssistantChatMessage
  • AssistantChatRequest
  • AssistantChatResource
  • AssistantChatResponse

@jdubois
Copy link
Contributor

jdubois commented Dec 2, 2024

Oh yes!! Can you do it?

@agoncal
Copy link
Contributor Author

agoncal commented Dec 2, 2024

Yes, I'll do it, but after our workshop tomorrow ;o)

@agoncal agoncal self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants