Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openid-configuration Repeat request #644

Closed
Buried-Love opened this issue Jul 5, 2021 · 20 comments
Closed

openid-configuration Repeat request #644

Buried-Love opened this issue Jul 5, 2021 · 20 comments

Comments

@Buried-Love
Copy link

When I log in, I log in successfully for the first time,But the VM requests againopenid-configuration. Cause me to report an error :
ResponseValidator._processSigninParams: Response was error login_required
openid-configuration The first request was made by oidc-client.main.js issue. The second request was made by VM.

please help me... thank you!

@guillaume-chervet
Copy link
Contributor

Sorry, we have a bug in version 3.1.7, you may retrograde to 3.1.6. It should work better.

@Buried-Love
Copy link
Author

Sorry, we have a bug in version 3.1.7, you may retrograde to 3.1.6. It should work better.

Thank you for your reply ! It's the same problem after switching versions.

@guillaume-chervet
Copy link
Contributor

Do you have the problem with exemples on that repo?

@Ansalibrahim
Copy link

I am using v3.1.6. It occurs in the incognito mode of chrome. And it happens in example too (context).

@Ansalibrahim
Copy link

I can confirm that this happens in all versions @3.1.+.

@Ansalibrahim
Copy link

The error is occurring inside the dependency oidc-client and it is deprecated 🤦‍♂️

@jafin
Copy link
Contributor

jafin commented Sep 15, 2021

@Ansalibrahim yes refer to #641 re deprecation

@Ansalibrahim
Copy link

@jafin Have you found any workarounds or anything of that sort?

@Ansalibrahim
Copy link

Screenshot 2021-09-15 at 9 34 53 AM

Here is the available log... just before this log, I signed in and 2 seconds later I got signed out.

@Ansalibrahim
Copy link

@Buried-Love Have you found any solutions?

@guillaume-chervet Could you help to workaround the issue?

@robertmadril
Copy link

Hello,

This issue was encountered while utilizing the HOC implementation of OidcSecure in react-oidc-context. The same logging output as described in previous posts were encountered while on version 3.1.6 and 3.1.7.

In order to bypass this, custom auth logic was implemented in the application which calls for the user via userManager.getUser() and determines the authentication route utilizing the login() functionality exposed by the useReactOidc hook exposed from the library.

However, please inform if anyone else has found an effective solution without having to use custom logic in the application code.

@allemas
Copy link

allemas commented Feb 4, 2022

Hello @robertmadril :)

Could you share an example? I'm afraid to do this wrong.

@guillaume-chervet
Copy link
Contributor

guillaume-chervet commented Feb 4, 2022

The coming v4 will fix this. The alpha is fonctionnal but I need to document it and Write à small migration guide.

@allemas
Copy link

allemas commented Feb 5, 2022

How can we help you to do it? Did you open a milestone?

@guillaume-chervet
Copy link
Contributor

guillaume-chervet commented Feb 5, 2022

Thank you for your answer. I do not know what is a Milestone. If you Want you can copy this branch https://github.com/AxaGuilDEv/react-oidc/tree/feature/v4
I have more test and documentation to do. Some feedback would be great. There are required breaking changes.

@TeckTn
Copy link
Contributor

TeckTn commented Feb 8, 2022

Is there any plan to upgrade oidc-redux package to v4 also?

@guillaume-chervet
Copy link
Contributor

Unfortunately i am not using redux any more in my current projects. I think that the vanilla oidc behind v4 is quite simple to use with redux. It would be great if someone could have the time to write a small redux wrapper.

@TeckTn
Copy link
Contributor

TeckTn commented Feb 9, 2022

Thank you for your response and for this magnifique repo.
Unfortunately am not enough skilled to make a pr for now.
I will just migrate to vanilla js.

@guillaume-chervet
Copy link
Contributor

v4 context version does not really use context (I will remove it).
It may be already redux compatible.
https://www.npmjs.com/package/@axa-fr/react-oidc-context/v/4.0.0-beta.9

@guillaume-chervet
Copy link
Contributor

I close the pull request. Feel free to reopen it if you need it.
Thank you very much. I think the v5 is simpler ans resolve that problem and is full compatible with a react redux architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants