Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Commit 620ebf7

Browse files
committed
Merge branch 'dev'
2 parents 87bc814 + ae7d666 commit 620ebf7

File tree

3 files changed

+25
-29
lines changed

3 files changed

+25
-29
lines changed

browseapi/client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from . import exceptions
1111
from .containers import BrowseAPIResponse
1212

13-
TIMEOUT = 5
13+
TIMEOUT = 10
1414

1515

1616
class BrowseAPI(object):

browseapi/containers.py

+22-26
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,18 @@ class ItemSummary(BrowseAPIBaseContainer):
6969
"""
7070

7171
def __init__(self, item_summary: dict):
72-
self.adultOnly = item_summary['adultOnly']
73-
self.buyingOptions = item_summary['buyingOptions']
74-
self.conditionId = item_summary['conditionId']
72+
self.adultOnly = item_summary.get('adultOnly')
73+
self.buyingOptions = item_summary.get('buyingOptions')
74+
self.conditionId = item_summary.get('conditionId')
7575
self.image = Image(item_summary['image'])
76-
self.itemHref = item_summary['itemHref']
77-
self.itemId = item_summary['itemId']
76+
self.itemHref = item_summary.get('itemHref')
77+
self.itemId = item_summary.get('itemId')
7878
self.itemLocation = ItemLocationImpl(item_summary['itemLocation'])
79-
self.itemWebUrl = item_summary['itemWebUrl']
79+
self.itemWebUrl = item_summary.get('itemWebUrl')
8080
self.price = ConvertedAmount(item_summary['price'])
8181
self.seller = Seller(item_summary['seller'])
8282
self.shortDescription = item_summary.get('shortDescription')
83-
self.title = item_summary['title']
83+
self.title = item_summary.get('title')
8484
self.unitPricingMeasure = item_summary.get('unitPricingMeasure')
8585

8686
for key in ('bidCount',
@@ -143,7 +143,7 @@ class Category(BrowseAPIBaseContainer):
143143
"""
144144

145145
def __init__(self, category: dict):
146-
self.categoryId = category['categoryId']
146+
self.categoryId = category.get('categoryId')
147147

148148

149149
class CompatibilityProperty(BrowseAPIBaseContainer):
@@ -164,8 +164,8 @@ class ConvertedAmount(BrowseAPIBaseContainer):
164164
"""
165165

166166
def __init__(self, current_price: dict):
167-
self.currency = current_price['currency']
168-
self.value = current_price['value']
167+
self.currency = current_price.get('currency')
168+
self.value = current_price.get('value')
169169

170170
for key in 'convertedFromCurrency', 'convertedFromValue':
171171
setattr(self, key, current_price.get(key))
@@ -189,9 +189,7 @@ class ItemLocationImpl(BrowseAPIBaseContainer):
189189
"""
190190

191191
def __init__(self, location: dict):
192-
self.country = location['country']
193-
194-
for key in 'addressLine1', 'addressLine2', 'city', 'county', 'stateOrProvince', 'postalCode':
192+
for key in 'addressLine1', 'addressLine2', 'city', 'country', 'county', 'stateOrProvince', 'postalCode':
195193
setattr(self, key, location.get(key))
196194

197195

@@ -202,9 +200,7 @@ class MarketingPrice(BrowseAPIBaseContainer):
202200
"""
203201

204202
def __init__(self, price: dict):
205-
self.discountPercentage = price.get('discountPercentage')
206-
207-
for key in 'currency', 'value':
203+
for key in 'discountPercentage', 'currency', 'value':
208204
setattr(self, key, price.get(key))
209205

210206
if 'discountAmount' in price:
@@ -349,14 +345,15 @@ class ErrorDetailV3(BrowseAPIBaseContainer):
349345
"""
350346

351347
def __init__(self, warning: dict):
352-
self.category = warning['category']
353-
self.domain = warning['domain']
354-
self.errorId = warning['errorId']
355-
self.message = warning['message']
356-
357-
for key in 'inputRefIds', 'longMessage', 'outputRefIds', 'subdomain':
358-
if key in warning:
359-
setattr(self, key, warning[key])
348+
for key in ('category',
349+
'domain',
350+
'errorId',
351+
'message',
352+
'inputRefIds',
353+
'longMessage',
354+
'outputRefIds',
355+
'subdomain'):
356+
setattr(self, key, warning.get(key))
360357

361358
if 'parameters' in warning:
362359
self.parameters = [ErrorParameterV3(parameter) for parameter in warning['parameters']]
@@ -370,5 +367,4 @@ class ErrorParameterV3(BrowseAPIBaseContainer):
370367

371368
def __init__(self, parameter: dict):
372369
for key in 'name', 'value':
373-
if key in parameter:
374-
setattr(self, key, parameter[key])
370+
setattr(self, key, parameter.get(key))

setup.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
setup(
88
name='browseapi',
99
packages=['browseapi'],
10-
version='0.11',
10+
version='0.11.1',
1111
license='MIT',
1212
description='eBay Browse API Python client',
1313
long_description=long_description,
1414
author='Andrii Matiiash',
1515
author_email='[email protected]',
1616
url='https://github.com/AverHLV/browseapi',
17-
download_url='https://github.com/AverHLV/browseapi/archive/0.11.tar.gz',
17+
download_url='https://github.com/AverHLV/browseapi/archive/0.11.1.tar.gz',
1818
keywords=['ASYNC', 'BROWSE API', 'CLIENT'],
1919

2020
install_requires=[

0 commit comments

Comments
 (0)