api swallows http error??

[robmcguinness]

it seems we are always resolving successfully when making http request. if so, code should be modified to throw error so that try/catch works when async/await. This would be breaking change.

https://github.com/Availity/sdk-js/blob/master/packages/api-core/src/api.js#L179

request(config, afterResponse) {
  if (config.polling) {
    config.attempt = config.attempt || 0;
    config.attempt += 1;
  }

  return this.http(config)
    .then(response => this.onResponse(response, afterResponse))
    .catch(error => {
      const response = this.getError(error);
      // throw here ??? <<<===
      return afterResponse ? afterResponse(response) : response;
    });
}

[TheSharpieOne]

Also, this.getError doesn't seem to do anything useful.

sdk-js/packages/api-core/src/api.js

Lines 162 to 168 in 4595a86

	getError(error) {
	let response;
	if (error.response) {
	response = { error };
	}
	return response;
	}

if error.response exists, it will return it... else it will return undefined (and in a very awkward way)

[robmcguinness]

#80