Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Object.assign usage #299

Closed
nylon22 opened this issue Dec 21, 2020 · 1 comment
Closed

Remove Object.assign usage #299

nylon22 opened this issue Dec 21, 2020 · 1 comment

Comments

@nylon22
Copy link
Member

nylon22 commented Dec 21, 2020

🐛 Bug report

Current Behavior

Object.assign is used at the following locations:

Object.assign is not supported in IE:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Browser_compatibility

Expected behavior

Object.assign is not used

Suggested solution(s)

We either polyfill Object.assign or use the spread operator. or perhaps use the extend method from lodash. I'm partial to the spread operator.

@jordan-a-young
Copy link
Member

I vote for using the spread operator too. Looks like it should cover the cases listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants