Fix binary type translation and BLOB column tests

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -4622,9 +4622,9 @@ public function testNonStrictModeTypeCasting(): void {
 		$this->assertSame( '', $result[0]->col_text );
 		$this->assertSame( '0', $result[0]->col_bool );
 		$this->assertSame( '0', $result[0]->col_bit );
-		$this->assertSame( '0', $result[0]->col_binary ); // TODO: Should save ''.
-		$this->assertSame( '', $result[0]->col_varbinary );
-		$this->assertSame( '', $result[0]->col_blob );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_binary );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_varbinary );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_blob );
 		$this->assertSame( '0000-00-00', $result[0]->col_date );
 		$this->assertSame( '00:00:00', $result[0]->col_time );
 		$this->assertSame( '0000-00-00 00:00:00', $result[0]->col_datetime );
@@ -4671,9 +4671,9 @@ public function testNonStrictModeTypeCasting(): void {
 		$this->assertSame( '', $result[0]->col_text );
 		$this->assertSame( '0', $result[0]->col_bool );
 		$this->assertSame( '0', $result[0]->col_bit );
-		$this->assertSame( '0', $result[0]->col_binary ); // TODO: Should save ''.
-		$this->assertSame( '', $result[0]->col_varbinary );
-		$this->assertSame( '', $result[0]->col_blob );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_binary );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_varbinary );
+		$this->assertSame( PHP_VERSION_ID < 80100 ? null : '', $result[0]->col_blob );
 		$this->assertSame( '0000-00-00', $result[0]->col_date );
 		$this->assertSame( '00:00:00', $result[0]->col_time );
 		$this->assertSame( '0000-00-00 00:00:00', $result[0]->col_datetime );

tests/WP_SQLite_Driver_Translation_Tests.php

@@ -1110,7 +1110,7 @@ public function testDateAndTimeDataTypes(): void {
 
 	public function testBinaryDataTypes(): void {
 		$this->assertQuery(
-			'CREATE TABLE `t` ( `b` INTEGER, `v` BLOB ) STRICT',
+			'CREATE TABLE `t` ( `b` BLOB, `v` BLOB ) STRICT',
 			'CREATE TABLE t (b BINARY, v VARBINARY(255))'
 		);
 

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -94,7 +94,7 @@ class WP_SQLite_Driver {
 		WP_MySQL_Lexer::YEAR_SYMBOL               => 'TEXT',
 
 		// Binary data types:
-		WP_MySQL_Lexer::BINARY_SYMBOL             => 'INTEGER',
+		WP_MySQL_Lexer::BINARY_SYMBOL             => 'BLOB',
 		WP_MySQL_Lexer::VARBINARY_SYMBOL          => 'BLOB',
 		WP_MySQL_Lexer::TINYBLOB_SYMBOL           => 'BLOB',
 		WP_MySQL_Lexer::BLOB_SYMBOL               => 'BLOB',
@@ -162,7 +162,7 @@ class WP_SQLite_Driver {
 		'year'               => 'TEXT',
 
 		// Binary data types:
-		'binary'             => 'INTEGER',
+		'binary'             => 'BLOB',
 		'varbinary'          => 'BLOB',
 		'tinyblob'           => 'BLOB',
 		'blob'               => 'BLOB',