has_lib.js gif detects libgif, but needs to detect libgif-dev specifically

[domoritz]

I am trying to install node canvas without libgif-dev.

The readme says it's optional

But my builds fail when I don't have it installed

Is this expected?

Your Environment

https://github.com/vega/vega-lite/pull/6406/checks?check_run_id=634869864

[zbjornson]

It looks like the GitHub Actions Ubuntu runner has libgif7 (giflib) already installed, but not libgif-dev, so the headers are missing:

$ ldconfig -p 2>/dev/null | grep -E gif
libgif.so.7 (libc6,x86-64) => /usr/lib/x86_64-linux-gnu/libgif.so.7

$ apt list --installed | grep gif
libgif7/bionic-updates,bionic-security,now 5.1.4-2ubuntu0.1 amd64 [installed,automatic]

(From https://github.com/zbjornson/node-canvas/runs/635551205?check_suite_focus=true)

I can't find the issue where this was discussed, but instead of using ldconfig we should be doing something like gcc -lgif and seeing if it succeeds.

The easiest fix for now is to install the other dependencies. Prebuilds for v14 should be here soon (#1568).

[domoritz]

Thanks for the update and for pointing me to #1568.