Skip to content

Make benchmarks use Mongoose in package.json and npm pack #12320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
vkarpov15 opened this issue Aug 23, 2022 · 0 comments · Fixed by #12345
Closed
2 tasks done

Make benchmarks use Mongoose in package.json and npm pack #12320

vkarpov15 opened this issue Aug 23, 2022 · 0 comments · Fixed by #12345
Assignees
@vkarpov15
Labels
developer-experience This issue improves error messages, debugging, or reporting
Milestone
6.5.5

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Our TypeScript benchmarks missed a perf regression (see #10349 later discussions) that popped up around 6.3.2. Because I suspect something strange is going on with using paths and importing Mongoose's index.d.ts from top level, as opposed to installing with npm:

mongoose/benchmarks/typescript/simple/tsconfig.json

Line 6 in 8c0800a

"mongoose": ["../../../"]
.

We should be able to work around this in GitHub Workflows using npm pack
@vkarpov15 vkarpov15 added the developer-experience This issue improves error messages, debugging, or reporting label Aug 23, 2022
@vkarpov15 vkarpov15 added this to the 6.5.4 milestone Aug 23, 2022
@vkarpov15 vkarpov15 self-assigned this Aug 23, 2022
@vkarpov15 vkarpov15 mentioned this issue Aug 23, 2022
Closed
vkarpov15 pushed a commit that referenced this issue Aug 28, 2022
chore: use npm pack for typescript benchmark re: #12320
caddb67
vkarpov15 pushed a commit that referenced this issue Aug 28, 2022
chore: working ts benchmark re: #12320
7c26914
@vkarpov15 vkarpov15 mentioned this issue Aug 28, 2022
Merged
@vkarpov15 vkarpov15 modified the milestones: 6.5.4, 6.5.5 Aug 30, 2022
Uzlopak pushed a commit that referenced this issue Aug 30, 2022
@vkarpov15
Use npm pack to npm install Mongoose for TypeScript benchmarks (#12345)
24a08fe 
* chore: use npm pack for typescript benchmark re: #12320

* chore: working ts benchmark re: #12320

* Revert "perf(types): remove `extends Query` in Schema.pre() and Schema.post(), loosen `discriminator()` generic"

This reverts commit b1c66c2.

* chore: run tests

* Revert "chore: run tests"

This reverts commit 7079cc6.

* Revert "Revert "perf(types): remove `extends Query` in Schema.pre() and Schema.post(), loosen `discriminator()` generic""

This reverts commit 080c5ca.

Co-authored-by: ts-benchmark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkarpov15 vkarpov15

Labels
developer-experience This issue improves error messages, debugging, or reporting
Projects
None yet
Milestone
6.5.5
Development

Successfully merging a pull request may close this issue.

Use npm pack to npm install Mongoose for TypeScript benchmarks Automattic/mongoose
1 participant
@vkarpov15