Skip to content

Commit 8e57c9c

Browse files
tbradshaanomiex
andauthored
PHP 8.4: Set as default (#45807)
Co-authored-by: Brad Jorsch <[email protected]>
1 parent c871576 commit 8e57c9c

File tree

55 files changed

+3969
-5158
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+3969
-5158
lines changed

.github/versions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Versions of tools to use in CI.
2-
PHP_VERSION=8.2
2+
PHP_VERSION=8.4
33
COMPOSER_VERSION=2.8.12
44
NODE_VERSION=22.12.0
55
PNPM_VERSION=10.4.0

composer.lock

Lines changed: 45 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/coding-guidelines.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ If you take a look at the contents of the `projects` folder, you can see that th
2525

2626
## The Jetpack Monorepo and its CLI
2727

28-
Jetpack CLI requires PHP 8.2 and latest stable Node JS versions. Sometimes the version update lags behind for a while to make sure that [Calypso is using the same version](https://github.com/Automattic/wp-calypso/blob/trunk/.nvmrc).
28+
Jetpack CLI requires PHP 8.4 and latest stable Node JS versions. Sometimes the version update lags behind for a while to make sure that [Calypso is using the same version](https://github.com/Automattic/wp-calypso/blob/trunk/.nvmrc).
2929

3030
Jetpack CLI is a requirement to work with Jetpack Monorepo, and it depends on the following tools:
3131

docs/monorepo.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ On most Linux distributions, you can install the PHP ast extension using your pa
213213

214214
- For Ubuntu/Debian-based systems:
215215
```
216-
sudo apt-get install php8.2-ast
216+
sudo apt-get install php8.4-ast
217217
```
218218
- For Arch Linux:
219219
Install the AUR package "php-ast" from https://aur.archlinux.org/packages/php-ast
@@ -226,7 +226,7 @@ Mac users have reported having trouble installing the PHP ast extension. See the
226226
227227
<details><summary>Installing the PHP ast extension on Mac</summary>
228228
229-
This assumes you have PHP installed via Homebrew, e.g. you've done `brew install php@8.2`.
229+
This assumes you have PHP installed via Homebrew, e.g. you've done `brew install php@8.4`.
230230
231231
1. First, check whether ast is already installed by running `php --ri ast`. If it prints something like this, you should already be good (unless you need a newer version; see [Phan's README](https://github.com/phan/phan#getting-started) for version requirements):
232232
```
@@ -326,7 +326,7 @@ On most Linux distributions, you can install the PHP pcov extension using your p
326326
327327
- For Ubuntu/Debian-based systems:
328328
```
329-
sudo apt-get install php8.2-pcov
329+
sudo apt-get install php8.4-pcov
330330
```
331331
- For Arch Linux:
332332
Install the AUR package "php-pcov" from https://aur.archlinux.org/packages/php-pcov
@@ -339,7 +339,7 @@ Mac users have reported having trouble installing the PHP pcov extension. See th
339339
340340
<details><summary>Installing the PHP pcov extension on Mac</summary>
341341
342-
This assumes you have PHP installed via Homebrew, e.g. you've done `brew install php@8.2`.
342+
This assumes you have PHP installed via Homebrew, e.g. you've done `brew install php@8.4`.
343343
344344
1. First, check whether pcov is already installed by running `php --ri pcov`. If it prints something like this, you should already be good:
345345
```
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Significance: patch
2+
Type: changed
3+
Comment: Update coverage munging for PHPUnit 12.
4+
5+

projects/packages/autoloader/tests/php/bin/test-coverage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ function get_path_transformation_map( $report_file_paths ) {
165165
*
166166
* @phan-suppress PhanAccessMethodInternal -- There's not really a way to avoid this.
167167
*/
168-
function process_coverage_11( $report ) {
168+
function process_coverage_12( $report ) {
169169
$data = $report->getData( true );
170170
$classname = get_class( $data );
171171

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Significance: patch
2+
Type: fixed
3+
Comment: Fix PHPUnit CoversFunction, leading backslash is not allowed.
4+
5+
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Significance: patch
2+
Type: changed
3+
Comment: Update composer.lock
4+
5+

0 commit comments

Comments
 (0)