Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 9b14ca8

Browse files
committed
CI: Remove cache dependencies job to ignore save gradle dependency cache
With this job present, every tag related build tries to save the dependencies in a cache, but, this functionality has been broken for a while, the 'example:build' task is constantly failing on CI (see below). Example Build (1.23.1): https://buildkite.com/automattic/ android-dependency-catalog/builds/189 #01922323-d7e6-4526-82b5-f5dca9e6ed6a FYI: No matter, we have decided to not use this project for this purpose, as as such to have a single dependency cache for all projects, and then restore this bigger than needed cache per project, only to use a specific set of dependencies per project. Instead, we decided it is better for each project to have a scheduled job, either weekly or daily, which will trigger this 'save_gradle_dependency_cache' script and only save the dependencies that it really needs.
1 parent d76c2b2 commit 9b14ca8

File tree

3 files changed

+2
-27
lines changed

3 files changed

+2
-27
lines changed

Diff for: .buildkite/cache.sh

-10
This file was deleted.

Diff for: .buildkite/pipeline.yml

-8
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,3 @@ steps:
2626
plugins: *common_plugins
2727
command: |
2828
.buildkite/publish.sh
29-
30-
- label: "Cache dependencies"
31-
depends_on:
32-
- "publish"
33-
if: build.tag != null
34-
plugins: *common_plugins
35-
command: |
36-
.buildkite/cache.sh

Diff for: README.md

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Android Dependency Catalog
22

3-
This project is a shared Android dependency catalog for Automattic projects which uses [Gradle's version catalog feature](https://docs.gradle.org/current/userguide/platforms.html). It's also used for generating a dependency cache that we use in our CIs to speed up our builds.
3+
This project is a shared Android dependency catalog for Automattic projects which uses [Gradle's version catalog feature](https://docs.gradle.org/current/userguide/platforms.html).
44

55
## Table of Contents
66

@@ -10,7 +10,6 @@ This project is a shared Android dependency catalog for Automattic projects whic
1010
* [Releasing a new catalog version](#releasing-a-new-catalog-version)
1111
* [Naming conventions](#naming-conventions)
1212
* [Building locally](#building-locally)
13-
* [Dependency caching](#dependency-caching)
1413
* [Automatically updating dependency versions in the catalog](#automatically-updating-dependency-versions-in-the-catalog)
1514
* [Setting up your projects to automatically update the catalog version](#setting-up-your-projects-to-automatically-update-the-catalog-version)
1615

@@ -61,7 +60,7 @@ See [Gradle documentation](https://docs.gradle.org/current/userguide/platforms.h
6160
androidx-recyclerview = { module = "androidx.recyclerview:recyclerview", version.ref = "androidx-recyclerview" }
6261
```
6362
* `version.ref` refers to the version name from `[versions]` section in the [libs.versions.toml](libs.versions.toml) file
64-
* If this is a new plugin, add it under `plugins` section in [example/build.gradle.kts](example/build.gradle.kts) - make sure to add `.apply(false)`. This step is necessary because we use the `example` module to generate a dependency cache we use to speed up CI in other projects. We are able to automatically add the library dependencies, so this step is not necessary, but plugins need to be added manually.
63+
* If this is a new plugin, add it under `plugins` section in [example/build.gradle.kts](example/build.gradle.kts) - make sure to add `.apply(false)`. We are able to automatically add the library dependencies, so this step is not necessary, but plugins need to be added manually.
6564
* [Build the catalog & example projects](#building-locally) - if you get `Could not find {dependency}` error, make sure the repository for the new dependency you've added is included in [example/settings.gradle.kts](example/settings.gradle.kts)
6665
* Follow the instructions for [releasing a new catalog version](#releasing-a-new-catalog-version)
6766

@@ -93,12 +92,6 @@ We'll need to iterate on our naming conventions, but here are some general guide
9392

9493
**Note that `example` project does NOT use the generated version catalog from the `catalog` project.** Although this is not likely to cause a difference in practice, it's an important distinction to be aware of.
9594

96-
## Dependency caching
97-
98-
We use the `example` project to generate a dependency cache which is uploaded to S3 by CI and then used in several projects.
99-
100-
Note that all libraries within the version catalog will be automatically added as a dependency to the `example` project, but the plugins need to be added manually.
101-
10295
## Automatically updating dependency versions in the catalog
10396

10497
This feature is not available yet.

0 commit comments

Comments
 (0)