Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install_npm_packages based on Studio build process #94

Open
1 task
wojtekn opened this issue May 27, 2024 · 0 comments · May be fixed by #96
Open
1 task

Improve install_npm_packages based on Studio build process #94

wojtekn opened this issue May 27, 2024 · 0 comments · May be fixed by #96
Assignees

Comments

@wojtekn
Copy link

wojtekn commented May 27, 2024

From: https://github.com/Automattic/studio/pull/166/files#r1613715724

The install_npm_packages command installs NPM packages. It was a bit limited for Studio, so Studio used a custom shell script, with the notable differences:

  • use patches/ directory to build a cache key
  • use npm ci vs npm install

Let's review if it makes sense to bring those improvements upstream and use the main command in Studio.

Done is:

  • We review if it's with porting Studio NPM install script to upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants