Skip to content

Commit 532869a

Browse files
Merge branch '5-playwright-tricks' into 6-api-testing
2 parents 22eacd8 + 3056997 commit 532869a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tutorial/4-page-objects.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ Now, it just uses a page object for the search page instead of raw calls.
189189

190190
After writing the search page class, the result page class will be straightforward.
191191
It will follow the same structure.
192-
The main difference is that each interaction methods in the result page class will return a value
192+
The main difference is that each interaction method in the result page class will return a value
193193
because test assertions will check page values.
194194

195195
Start by adding the following imports for type checking to `pages/result.py`:
@@ -244,11 +244,11 @@ it is concatenated with the N-th element fetcher to wait for at least 5 elements
244244
The second time it is called,
245245
it gets all the text contents for the elements it finds.
246246

247-
The second method takes in a search phases and a minimum limit for matches.
247+
The second method takes in a search phrase and a minimum limit for matches.
248248
It calls the first method to get the list of titles,
249249
filters the titles using a list comprehension,
250250
and returns a Boolean value indicating if the number of matches meets the minimum threshold.
251-
Notice that this method does **not** perform an asssertion.
251+
Notice that this method does **not** perform an assertion.
252252
Assertions should *not* be done in page objects.
253253
They should only be done in test cases.
254254

0 commit comments

Comments
 (0)