Skip to content

Commit 6869fbf

Browse files
committed
Improve common review items list. #2.
1 parent f13096b commit 6869fbf

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

contributing.md

+9-8
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,16 @@ podman stop $CID && podman rm $CID
3131
```
3232

3333
### Common review items
34-
* Add authentication to the configuration class.
35-
* Change configuration class name to be consistent
34+
* [ ] Add authentication to the configuration class.
35+
* [ ] Change configuration class name to be consistent
3636
* Specify all the inputs to be consistent across languages
37-
* Update documentation
37+
* [ ] Update documentation
3838
* Make sure markdown is valid
3939
* Remove unnecessary links
4040
* Add first class examples to readme.md + api documentation
41-
* Url encode all url inputs, frequently the generator doesn't do that
42-
* Remove any unnecessary validations from object and parameter injection, often there are some even when properties are allowed to be null
43-
* The service client code to generate a JWT from private key needs to be added
44-
* Top level tags from the API should accessible from the base class: `authressClient.accessRecords.getRecords(...)`
45-
* Test
41+
* [ ] Url encode all url inputs, frequently the generator doesn't do that
42+
* [ ] Remove any unnecessary validations from object and parameter injection, often there are some even when properties are allowed to be null
43+
* [ ] The service client code to generate a JWT from private key needs to be added
44+
* [ ] Add UnauthorizedError type to the authorizeUser function
45+
* [ ] Top level tags from the API should accessible from the base class: `authressClient.accessRecords.getRecords(...)`
46+
* [ ] Test

0 commit comments

Comments
 (0)