Skip to content

Add Version number to custom section #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willemneal opened this issue Oct 14, 2019 · 4 comments
Closed

Add Version number to custom section #907

willemneal opened this issue Oct 14, 2019 · 4 comments
Labels

Comments

@willemneal
Copy link
Contributor

Adding this here to track it. With binaryen's support for creating custom sections, it would be a good idea to add the version of the compiler used to generate the binary in a custom section.

@dcodeIO
Copy link
Member

dcodeIO commented Oct 14, 2019

Related: There's a producers section under tool conventions but that's a bit controversial.

@willemneal
Copy link
Contributor Author

Ah I see. I think that we should just have it as an option. For example, having it for smart contracts where you only need the full binary once.

@dcodeIO
Copy link
Member

dcodeIO commented Oct 21, 2019

Btw, with the new transforms, it should be possible to append additional custom sections to a binary, incl. potential additional version numbers not just of asc but also other parts of the specific toolchain being used.

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 20, 2019
@stale stale bot closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants