Skip to content

Adding support for SavedModel for converting model to tfjs_graph_model #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binary-person opened this issue Apr 23, 2019 · 6 comments

Comments

@binary-person
Copy link

The title says it all. Do you have time to make this enhancement?

@ArunMichaelDsouza
Copy link
Owner

Hi @scheng123, can you please explain what this enhancement would do? Also, I would really appreciate a PR if you have the time. 🙂

@binary-person
Copy link
Author

binary-person commented Apr 23, 2019

Since I’m experienced in web development, I was planning to have the program export it’s own JavaScript model, so I can later on incorporate that into a browser, which would be cool! And also, since I’m new to python, I have no idea how to do that (tried everything), although it would be awesome if I could make a PR. Do you have the time? I always love learning new things. 😊

@binary-person
Copy link
Author

binary-person commented Apr 24, 2019

Looks like its impossible since the inception model was using a deprecated BatchNormWithGlobalNormalization, and an unsupported DecodeJpeg. Nice try though. Anyway, apart from the fact that converting it to a javascript model won't work anyway, you want me to make a pull request for adding support for the checkpoint and SavedModel saving feature?

@ArunMichaelDsouza
Copy link
Owner

Yes ofcourse, that would be great!

@binary-person
Copy link
Author

binary-person commented Apr 29, 2019

Added checkpoint, and SavedModel saving feature. Also added a CTRL+C save as an extra bonus. As my use of language differs from yours, can you update the README.md to update the ability to save with the combination of CTRL+C? As always, I love to help out!
Check the code before merging, because I'm terrible at python.
Pull request: #14

@ArunMichaelDsouza
Copy link
Owner

Thanks a lot @scheng123! Please view #14 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants