Skip to content

Commit 9331730

Browse files
committed
Add FC in ResourceIdentifier
1 parent ca0b501 commit 9331730

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

src/V1/ResourceIdentifier.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,12 @@ protected function parse(mixed $object): void
4747
throw new ValidationException('A resource id MUST be a string');
4848
}
4949

50-
$this->set('type', $object->type);
51-
$this->set('id', $object->id);
52-
53-
if (property_exists($object, 'meta')) {
54-
$this->set('meta', $this->create('Meta', $object->meta));
50+
foreach (get_object_vars($object) as $key => $value) {
51+
if ($key === 'meta') {
52+
$this->set('meta', $this->create('Meta', $value));
53+
} else {
54+
$this->set($key, $value);
55+
}
5556
}
5657
}
5758

tests/Unit/V1/ResourceIdentifierTest.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,21 @@ public function testCreateWithObjectAndMeta(): void
6060
$object->type = 'types';
6161
$object->id = '159';
6262
$object->meta = new \stdClass();
63+
$object->fc = 'test property for forward compatability';
6364

6465
$identifier = new ResourceIdentifier($object, $this->manager, $this->parent);
6566

6667
$this->assertInstanceOf(ResourceIdentifier::class, $identifier);
6768

68-
$this->assertSame($identifier->get('type'), 'types');
69-
$this->assertSame($identifier->get('id'), '159');
69+
$this->assertSame(['type', 'id', 'meta', 'fc'], $identifier->getKeys());
70+
$this->assertTrue($identifier->has('type'));
71+
$this->assertSame('types', $identifier->get('type'));
72+
$this->assertTrue($identifier->has('id'));
73+
$this->assertSame('159', $identifier->get('id'));
7074
$this->assertTrue($identifier->has('meta'));
7175
$this->assertInstanceOf(Accessable::class, $identifier->get('meta'));
72-
$this->assertSame($identifier->getKeys(), ['type', 'id', 'meta']);
76+
$this->assertTrue($identifier->has('fc'));
77+
$this->assertSame('test property for forward compatability', $identifier->get('fc'));
7378
}
7479

7580
/**

0 commit comments

Comments
 (0)