Skip to content

Commit 7c34c0d

Browse files
committed
Add ruleset @PHPUnit84Migration
1 parent f155f88 commit 7c34c0d

File tree

7 files changed

+16
-14
lines changed

7 files changed

+16
-14
lines changed

.php-cs-fixer.dist.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
'@PER-CS2.0:risky' => true,
1616
'@PHP74Migration' => true,
1717
'@PHP74Migration:risky' => true,
18+
'@PHPUnit84Migration:risky' => true,
19+
'no_alias_functions' => true,
1820
])
1921
->setFinder($finder)
2022
->setRiskyAllowed(true)

tests/Unit/V1/AttributesTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ public function testCreateWithObject(): void
5353

5454
$this->assertInstanceOf(Accessable::class, $attributes);
5555
$this->assertTrue($attributes->has('object'));
56-
$this->assertTrue(is_object($attributes->get('object')));
56+
$this->assertIsObject($attributes->get('object'));
5757
$this->assertTrue($attributes->has('array'));
58-
$this->assertTrue(is_array($attributes->get('array')));
58+
$this->assertIsArray($attributes->get('array'));
5959
$this->assertTrue($attributes->has('string'));
60-
$this->assertTrue(is_string($attributes->get('string')));
60+
$this->assertIsString($attributes->get('string'));
6161
$this->assertTrue($attributes->has('number_int'));
62-
$this->assertTrue(is_int($attributes->get('number_int')));
62+
$this->assertIsInt($attributes->get('number_int'));
6363
$this->assertTrue($attributes->has('number_float'));
64-
$this->assertTrue(is_float($attributes->get('number_float')));
64+
$this->assertIsFloat($attributes->get('number_float'));
6565
$this->assertTrue($attributes->has('true'));
6666
$this->assertTrue($attributes->get('true'));
6767
$this->assertTrue($attributes->has('false'));

tests/Unit/V1/JsonapiTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,6 @@ public function testVersionCannotBeAnObjectOrArray($input): void
116116

117117
// other input must be transformed to string
118118
$this->assertTrue($jsonapi->has('version'));
119-
$this->assertTrue(is_string($jsonapi->get('version')));
119+
$this->assertIsString($jsonapi->get('version'));
120120
}
121121
}

tests/Unit/V1/LinkTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public function testHrefHasToBeAString($input): void
7979
$link = new Link($object, $this->manager, $this->parent);
8080

8181
$this->assertTrue($link->has('href'));
82-
$this->assertTrue(is_string($link->get('href')));
82+
$this->assertIsString($link->get('href'));
8383

8484
return;
8585
}

tests/Unit/V1/MetaTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ public function testCreateWithObject(): void
5353

5454
$this->assertInstanceOf(Accessable::class, $meta);
5555
$this->assertTrue($meta->has('object'));
56-
$this->assertTrue(is_object($meta->get('object')));
56+
$this->assertIsObject($meta->get('object'));
5757
$this->assertTrue($meta->has('array'));
58-
$this->assertTrue(is_array($meta->get('array')));
58+
$this->assertIsArray($meta->get('array'));
5959
$this->assertTrue($meta->has('string'));
60-
$this->assertTrue(is_string($meta->get('string')));
60+
$this->assertIsString($meta->get('string'));
6161
$this->assertTrue($meta->has('number_int'));
62-
$this->assertTrue(is_int($meta->get('number_int')));
62+
$this->assertIsInt($meta->get('number_int'));
6363
$this->assertTrue($meta->has('number_float'));
64-
$this->assertTrue(is_float($meta->get('number_float')));
64+
$this->assertIsFloat($meta->get('number_float'));
6565
$this->assertTrue($meta->has('true'));
6666
$this->assertTrue($meta->get('true'));
6767
$this->assertTrue($meta->has('false'));

tests/Unit/V1/RelationshipTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public function testCreateWithDataNull(): void
153153
$this->assertSame($relationship->getKeys(), ['data']);
154154
$this->assertTrue($relationship->has('data'));
155155

156-
$this->assertTrue(is_null($relationship->get('data')));
156+
$this->assertNull($relationship->get('data'));
157157
}
158158

159159
/**

tests/Unit/V1/ResourceIdentifierTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public function testTypeMustBeAString($input): void
9191

9292
$identifier = new ResourceIdentifier($object, $this->manager, $this->parent);
9393

94-
$this->assertTrue(is_string($identifier->get('type')));
94+
$this->assertIsString($identifier->get('type'));
9595
}
9696

9797
/**

0 commit comments

Comments
 (0)