Set Factory to final

Author: Art4

src/Utils/Factory.php

@@ -4,7 +4,7 @@
 
 use Art4\JsonApiClient\Exception\FactoryException;
 
-class Factory implements FactoryInterface
+final class Factory implements FactoryInterface
 {
 	/**
 	 * @var array

tests/Fixtures/Factory.php

@@ -2,9 +2,9 @@
 
 namespace Art4\JsonApiClient\Tests\Fixtures;
 
-use Art4\JsonApiClient\Utils\Factory as OrigFactory;
+use Art4\JsonApiClient\Utils\FactoryInterface;
 
-class Factory extends OrigFactory
+final class Factory implements FactoryInterface
 {
 	public $testcase;
 
@@ -17,11 +17,8 @@ class Factory extends OrigFactory
 	 */
 	public function make($name, array $args = [])
 	{
-		if ( isset($this->classes[$name]) )
-		{
-			return $this->testcase
-				->getMockBuilder($this->classes[$name] . 'Interface') // Mock only the interfaces
-				->getMock();
-		}
+		return $this->testcase
+			->getMockBuilder('Art4\JsonApiClient\\' . $name . 'Interface') // Mock only the interfaces
+			->getMock();
 	}
 }

tests/unit/Utils/ManagerTest.php

@@ -22,23 +22,23 @@ public function testCreateReturnsSelf()
 	 */
 	public function testCreateWithConstructorReturnsSelf()
 	{
-		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\Factory')
+		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\FactoryInterface')
 			->getMock();
 
 		$manager = new Manager($factory);
 
 		$this->assertInstanceOf('Art4\JsonApiClient\Utils\ManagerInterface', $manager);
 		$this->assertInstanceOf('Art4\JsonApiClient\Utils\FactoryManagerInterface', $manager);
 
-		$this->assertSame($factory, $manager->getFactory());
+		$this->assertInstanceOf('Art4\JsonApiClient\Utils\FactoryInterface', $manager->getFactory());
 	}
 
 	/**
 	 * @test
 	 */
 	public function testSetFactoryReturnsSelf()
 	{
-		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\Factory')
+		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\FactoryInterface')
 			->getMock();
 
 		$manager = new Manager;
@@ -51,7 +51,7 @@ public function testSetFactoryReturnsSelf()
 	 */
 	public function testGetFactoryReturnsFactoryInterface()
 	{
-		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\Factory')
+		$factory = $this->getMockBuilder('Art4\JsonApiClient\Utils\FactoryInterface')
 			->getMock();
 
 		$manager = (new Manager)->setFactory($factory);