Skip to content

Commit af8e575

Browse files
authored
chore: php 8.4 support (#116)
1 parent 929de22 commit af8e575

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
# - name: Setup PHP
3232
# uses: shivammathur/setup-php@v2
3333
# with:
34-
# php-version: "8.2"
34+
# php-version: "8.4"
3535
# extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
3636
# coverage: pcov
3737

@@ -65,7 +65,7 @@ jobs:
6565
- name: Setup PHP
6666
uses: shivammathur/setup-php@v2
6767
with:
68-
php-version: "8.2"
68+
php-version: "8.4"
6969
extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
7070
coverage: pcov
7171

@@ -74,6 +74,8 @@ jobs:
7474

7575
- name: Run php-cs-fixer
7676
run: composer format
77+
env:
78+
PHP_CS_FIXER_IGNORE_ENV: true # TODO: Remove this line when php-cs-fixer is updated
7779

7880
- uses: stefanzweifel/git-auto-commit-action@v4
7981
with:
@@ -94,7 +96,7 @@ jobs:
9496
- name: Setup PHP
9597
uses: shivammathur/setup-php@v2
9698
with:
97-
php-version: "8.2"
99+
php-version: "8.4"
98100
extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
99101
coverage: pcov
100102

src/API/Node.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function crypto(): ?array
5353
*
5454
* @return array
5555
*/
56-
public function fees(int $days = null): ?array
56+
public function fees(?int $days = null): ?array
5757
{
5858
return $this->get('node/fees', ['days' => $days]);
5959
}

src/ArkClient.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class ArkClient
4646
*
4747
* @throws InvalidArgumentException if $hostOrHosts is an array and does not have the required format
4848
*/
49-
public function __construct(array|string $hostOrHosts, array $clientConfig = [], HandlerStack $handler = null)
49+
public function __construct(array|string $hostOrHosts, array $clientConfig = [], ?HandlerStack $handler = null)
5050
{
5151
$this->validateHosts($hostOrHosts);
5252

src/ClientManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function connect(string $host, string $name = 'main'): ArkClient
4949
*
5050
* @param string|null $name
5151
*/
52-
public function disconnect(string $name = null): void
52+
public function disconnect(?string $name = null): void
5353
{
5454
$name = $name ?? $this->getDefaultClient();
5555

@@ -63,7 +63,7 @@ public function disconnect(string $name = null): void
6363
*
6464
* @return ArkClient
6565
*/
66-
public function client(string $name = null): ArkClient
66+
public function client(?string $name = null): ArkClient
6767
{
6868
$name = $name ?? $this->getDefaultClient();
6969

0 commit comments

Comments
 (0)