refactor: schema changes (#122)

Author: alexbarnsley

src/API/Commits.php

@@ -7,14 +7,14 @@
 class Commits extends AbstractAPI
 {
     /**
-     * Takes a block height and returns the commit details.
+     * Takes a block number and returns the commit details.
      *
      * @param int $id
      *
      * @return array
      */
-    public function get(int $height): ?array
+    public function get(int $number): ?array
     {
-        return $this->requestGet("commits/{$height}");
+        return $this->requestGet("commits/{$number}");
     }
 }

src/API/Rounds.php

@@ -31,14 +31,14 @@ public function get(int $round_id): ?array
     }
 
     /**
-     * Get the forging delegates of a round by the given id.
+     * Get the forging validators of a round by the given id.
      *
      * @param int $round_id
      *
      * @return array
      */
-    public function delegates(int $round_id): ?array
+    public function validators(int $round_id): ?array
     {
-        return $this->requestGet("rounds/{$round_id}/delegates");
+        return $this->requestGet("rounds/{$round_id}/validators");
     }
 }

src/API/Delegates.php renamed to src/API/Validators.php

@@ -4,7 +4,7 @@
 
 namespace ArkEcosystem\Client\API;
 
-class Delegates extends AbstractAPI
+class Validators extends AbstractAPI
 {
     /**
      * Get all accounts.
@@ -15,7 +15,7 @@ class Delegates extends AbstractAPI
      */
     public function all(array $query = []): ?array
     {
-        return $this->requestGet('delegates', $query);
+        return $this->requestGet('validators', $query);
     }
 
     /**
@@ -27,11 +27,11 @@ public function all(array $query = []): ?array
      */
     public function get(string $id): ?array
     {
-        return $this->requestGet("delegates/{$id}");
+        return $this->requestGet("validators/{$id}");
     }
 
     /**
-     * Get all blocks for the given delegate.
+     * Get all blocks for the given validator.
      *
      * @param string $id
      * @param array  $query
@@ -40,11 +40,11 @@ public function get(string $id): ?array
      */
     public function blocks(string $id, array $query = []): ?array
     {
-        return $this->requestGet("delegates/{$id}/blocks", $query);
+        return $this->requestGet("validators/{$id}/blocks", $query);
     }
 
     /**
-     * Get all voters for the given delegate.
+     * Get all voters for the given validator.
      *
      * @param string $id
      * @param array  $query
@@ -53,6 +53,6 @@ public function blocks(string $id, array $query = []): ?array
      */
     public function voters(string $id, array $query = []): ?array
     {
-        return $this->requestGet("delegates/{$id}/voters", $query);
+        return $this->requestGet("validators/{$id}/voters", $query);
     }
 }

tests/API/DelegatesTest.php

@@ -28,10 +28,10 @@ public function view_calls_correct_url()
     }
 
     /** @test */
-    public function delegates_calls_correct_url()
+    public function validators_calls_correct_url()
     {
-        $this->assertResponse('GET', 'rounds/12345/delegates', function ($client) {
-            return $client->rounds()->delegates(12345);
+        $this->assertResponse('GET', 'rounds/12345/validators', function ($client) {
+            return $client->rounds()->validators(12345);
         });
     }
 }

tests/API/RoundsTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ArkEcosystem\Tests\Client\API;
+
+use ArkEcosystem\Tests\Client\TestCase;
+
+/**
+ * @covers \ArkEcosystem\Client\API\Validators
+ */
+class ValidatorsTest extends TestCase
+{
+    /** @test */
+    public function all_calls_correct_url()
+    {
+        $this->assertResponse('GET', 'validators', function ($client) {
+            return $client->validators()->all();
+        });
+    }
+
+    /** @test */
+    public function get_calls_correct_url()
+    {
+        $this->assertResponse('GET', 'validators/dummy', function ($client) {
+            return $client->validators()->get('dummy');
+        });
+    }
+
+    /** @test */
+    public function blocks_calls_correct_url()
+    {
+        $this->assertResponse('GET', 'validators/dummy/blocks', function ($client) {
+            return $client->validators()->blocks('dummy');
+        });
+    }
+
+    /** @test */
+    public function voters_calls_correct_url()
+    {
+        $this->assertResponse('GET', 'validators/dummy/voters', function ($client) {
+            return $client->validators()->voters('dummy');
+        });
+    }
+}