Improve hash representation of library properties to support string conversion

Author: ianfixes

CHANGELOG.md

@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Rubocop expected syntax downgraded from ruby 2.6 to 2.5
 - `assertEqual()` and `assertNotEqual()` use actual `==` and `!=` -- they no longer require a type to be totally ordered just to do equality tests
 - Evaluative assertions (is true/false/null/etc) now produce simpler error messages instead of masquerading as an operation (e.g. "== true")
+- `LibraryProperties.to_h` now properly uses formatters and symbolic keys, in order to support a `.to_s`
 
 ### Deprecated
 

lib/arduino_ci/library_properties.rb

@@ -24,7 +24,12 @@ def initialize(path)
 
     # @return [Hash] the properties as a hash, all strings
     def to_h
-      @fields.clone
+      Hash[@fields.map { |k, _| [k.to_sym, send(k)] }]
+    end
+
+    # @return [String] the string representation
+    def to_s
+      to_h.to_s
     end
 
     # Enable a shortcut syntax for library property accessors, in the style of `attr_accessor` metaprogramming.

spec/library_properties_spec.rb

@@ -46,6 +46,14 @@
     it "doesn't crash on nonexistent fields" do
       expect(library_properties.dot_a_linkage).to be(nil)
     end
+
+    it "converts to hash" do
+      h = library_properties.to_h
+      expect(h[:name].class).to eq(String)
+      expect(h[:name]).to eq("WebServer")
+      expect(h[:architectures].class).to eq(Array)
+      expect(h[:architectures]).to contain_exactly("avr")
+    end
   end
 
   context "Input handling" do
@@ -65,5 +73,4 @@
     end
   end
 
-
 end