Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc service worker is hosted incorrectly by the plugin #4

Open
mahmoud34abc opened this issue Nov 13, 2023 · 2 comments
Open

Arc service worker is hosted incorrectly by the plugin #4

mahmoud34abc opened this issue Nov 13, 2023 · 2 comments

Comments

@mahmoud34abc
Copy link

I noticed that arc checks if the service worker is present at https://flashmedinfo.com/arc-sw.js , and I would get warnings that the file actually isn't there and is showing a 404 page. It turns out the WordPress plugin hosts it at https://flashmedinfo.com/arc-sw and so that's why the service worker does not "exist".

(I'll remove links when the issue is solved)

@mahmoud34abc
Copy link
Author

mahmoud34abc commented Nov 13, 2023

Hey, I'm really not familiar with how to commit or make a pull request, but I found the issue

https://github.com/Arc-io/Widget-WordPress-Plugin/blob/master/trunk/arc.php#L45

The proxy URL should be /arc-sw.js , not just /arc-sw

You might as well want to check the next line about the /arc-widget. I'm not sure if it's supposed to have .js or not

@mahmoud34abc
Copy link
Author

Here you go, that pull request should be enough to get the service worker back to working

#5

Still don't know how to link an issue to a pull request 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant