improve Thread_MergeSort

Aram-Vn · Aram-Vn · commit 8562f1bcd9df · 2024-10-29T19:03:38.000+04:00
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 .vscode
 Algorithmic_Techniques/
+.cache
diff --git a/Sorting_Algorithms/src/9__Thread_MergeSort.cpp b/Sorting_Algorithms/src/9__Thread_MergeSort.cpp
@@ -1,5 +1,6 @@
 #include "../include/Thread_MergeSort.h"
 
+// Merge two sorted halves
 void merge(std::vector<int>& arr, int left, int mid, int right)
 {
     int n1 = mid - left + 1;
@@ -15,32 +16,25 @@ void merge(std::vector<int>& arr, int left, int mid, int right)
     {
         if (arr[leftIdx] <= arr[rightIdx])
         {
-            merged.push_back(arr[leftIdx]);
-            leftIdx++;
+            merged.push_back(arr[leftIdx++]);
         }
         else
         {
-            merged.push_back(arr[rightIdx]);
-            rightIdx++;
+            merged.push_back(arr[rightIdx++]);
         }
     }
 
     while (leftIdx <= mid)
     {
-        merged.push_back(arr[leftIdx]);
-        leftIdx++;
+        merged.push_back(arr[leftIdx++]);
     }
 
     while (rightIdx <= right)
     {
-        merged.push_back(arr[rightIdx]);
-        rightIdx++;
+        merged.push_back(arr[rightIdx++]);
     }
 
-    for (int i = left; i <= right; i++)
-    {
-        arr[i] = merged[i - left];
-    }
+    std::move(merged.begin(), merged.end(), arr.begin() + left);
 }
 
 void mergeSort(std::vector<int>& arr, int left, int right, int depth)

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`#include "../include/Thread_MergeSort.h"`
`2`	`2`
	`3`	`+// Merge two sorted halves`
`3`	`4`	`void merge(std::vector<int>& arr, int left, int mid, int right)`
`4`	`5`	`{`
`5`	`6`	`int n1 = mid - left + 1;`
`@@ -15,32 +16,25 @@ void merge(std::vector<int>& arr, int left, int mid, int right)`
`15`	`16`	`{`
`16`	`17`	`if (arr[leftIdx] <= arr[rightIdx])`
`17`	`18`	`{`
`18`		`- merged.push_back(arr[leftIdx]);`
`19`		`- leftIdx++;`
	`19`	`+ merged.push_back(arr[leftIdx++]);`
`20`	`20`	`}`
`21`	`21`	`else`
`22`	`22`	`{`
`23`		`- merged.push_back(arr[rightIdx]);`
`24`		`- rightIdx++;`
	`23`	`+ merged.push_back(arr[rightIdx++]);`
`25`	`24`	`}`
`26`	`25`	`}`
`27`	`26`
`28`	`27`	`while (leftIdx <= mid)`
`29`	`28`	`{`
`30`		`- merged.push_back(arr[leftIdx]);`
`31`		`- leftIdx++;`
	`29`	`+ merged.push_back(arr[leftIdx++]);`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`while (rightIdx <= right)`
`35`	`33`	`{`
`36`		`- merged.push_back(arr[rightIdx]);`
`37`		`- rightIdx++;`
	`34`	`+ merged.push_back(arr[rightIdx++]);`
`38`	`35`	`}`
`39`	`36`
`40`		`- for (int i = left; i <= right; i++)`
`41`		`- {`
`42`		`- arr[i] = merged[i - left];`
`43`		`- }`
	`37`	`+ std::move(merged.begin(), merged.end(), arr.begin() + left);`
`44`	`38`	`}`
`45`	`39`
`46`	`40`	`void mergeSort(std::vector<int>& arr, int left, int right, int depth)`