[errormap] Move error maps into bytecode metadata. (aptos-labs#3220)

This moves the error explanation map (that info which allows to display reasons like `ESOME_REASON` and the related comment on Move Abort) into the metadata section of the Move bytecode and let it be interpreted by the Aptos VM. This is necessary as when we upgrade the framework, the error map  compiled into the binary becomes outdated. Also, this enables the same mechanism for user code.

There is now an optional `AbortInfo` embedded into an `ExecutionStatus` which the VM populates from the metadata. The overhead this creates should be marginal, and the deserialized metadata is cached on VM level.

A test in `e2e-move-tests/tests/error_map.rs` shows that it works.

As a consequence, explicit representation of errors maps in package metadata or elsewhere is not longer needed and has been removed.

Also the existing `error_explain` is not longer needed. This made the `sdk/aptos_transaction_builder` crate empty, and so I removed it. The crate served to re-export `cached-packages`, which let to some cascading changes. In general we should avoiding re-exports in our internal code base because it makes refactoring and reasoning about code harder. (It's ok to re-export for external APIs. If we need `aptos-transaction-builder` for this purpose we can re-introduce it, but it should not be used by our internal code.)

Author: wrwg

Diff for: Cargo.lock

@@ -85,7 +85,6 @@ members = [
     "network/peer-monitoring-service/server",
     "network/peer-monitoring-service/types",
     "sdk",
-    "sdk/transaction-builder",
     "secure/net",
     "secure/push-metrics",
     "secure/storage",

Diff for: Cargo.toml

@@ -1,5 +1,5 @@
 {
-  "bytecode": "0xa11ceb0b050000000a010004020410031446055a2f0789018202088b032006ab030a0ab503170ccc03ba020d8606080000000100020e000003060000040800000507000006000100000702030000080401000009050100000a060700000b060400000c080900000d000a00000e040700000f06030000100b070000110b04000012000c00011500040001060c01080102050301080301050205060800010608010103020608010608030101010800010608030002030708020467756964067369676e6572104372656174654361706162696c69747904475549440947656e657261746f7202494406637265617465096372656174655f69640b6372656174655f696d706c166372656174655f776974685f6361706162696c6974790c6372656174696f6e5f6e756d0f63726561746f725f616464726573730565715f69641567656e5f6372656174655f6361706162696c697479156765745f6e6578745f6372656174696f6e5f6e756d0269640f69645f6372656174696f6e5f6e756d1269645f63726561746f725f61646472657373117075626c6973685f67656e657261746f72046164647207636f756e7465720a616464726573735f6f6600000000000000000000000000000000000000000000000000000000000000010308000000000000000000020113050102010f080302020114030302020a031305000100010204120a00110d0c010a012902200308050d0b0006000000000000000012022d02050f0b00010b01110202010100000c040b010b0012030202000001020d120a002a020c020a021000140c010a01060100000000000000160b020f00150b010b00120312010203010001020c080a00290203050700270b00110202040100000c050b00100110021402050100000c050b00100110031402060100000c050b0010010b0121020701000004120a00110d0c010a012902200308050d0b0006000000000000000012022d02050f0b00010b011200020801000102070f0a00290220030505080600000000000000000c01050d0b002b021000140c010b0102090100000c040b00100114020a0100000c040b00100214020b0100000c040b00100314020c0100000c050b0006000000000000000012022d0202020001000300030100",
+  "bytecode": "0xa11ceb0b050000000b010004020410031446055a2f0789018202088b032006ab030a10b50398010acd04170ce404ba020d9e07080000000100020e000003060000040800000507000006000100000702030000080401000009050100000a060700000b060400000c080900000d000a00000e040700000f06030000100b070000110b04000012000c00011500040001060c01080102050301080301050205060800010608010103020608010608030101010800010608030002030708020467756964067369676e6572104372656174654361706162696c69747904475549440947656e657261746f7202494406637265617465096372656174655f69640b6372656174655f696d706c166372656174655f776974685f6361706162696c6974790c6372656174696f6e5f6e756d0f63726561746f725f616464726573730565715f69641567656e5f6372656174655f6361706162696c697479156765745f6e6578745f6372656174696f6e5f6e756d0269640f69645f6372656174696f6e5f6e756d1269645f63726561746f725f61646472657373117075626c6973685f67656e657261746f72046164647207636f756e7465720a616464726573735f6f66000000000000000000000000000000000000000000000000000000000000000103080000000000000000126170746f733a3a6d657461646174615f763083010100000000000000001d45475549445f47454e455241544f525f4e4f545f5055424c49534845445b475549442067656e657261746f72206d757374206265207075626c6973686564206168656164206f66206669727374207573616765206f6620606372656174655f776974685f6361706162696c697479602066756e6374696f6e2e00020113050102010f080302020114030302020a031305000100010204120a00110d0c010a012902200308050d0b0006000000000000000012022d02050f0b00010b01110202010100000c040b010b0012030202000001020d120a002a020c020a021000140c010a01060100000000000000160b020f00150b010b00120312010203010001020c080a00290203050700270b00110202040100000c050b00100110021402050100000c050b00100110031402060100000c050b0010010b0121020701000004120a00110d0c010a012902200308050d0b0006000000000000000012022d02050f0b00010b011200020801000102070f0a00290220030505080600000000000000000c01050d0b002b021000140c010b0102090100000c040b00100114020a0100000c040b00100214020b0100000c040b00100314020c0100000c050b0006000000000000000012022d0202020001000300030100",
   "abi": {
     "address": "0x1",
     "name": "guid",

Diff for: api/goldens/aptos_api__tests__state_test__test_get_account_module.json

@@ -53,7 +53,7 @@
         "data": {
           "type": "0x1::state_storage::StateStorageUsage",
           "data": {
-            "bytes": "301027",
+            "bytes": "295717",
             "epoch": "1",
             "items": "100"
           }

Diff for: api/goldens/aptos_api__tests__transactions_test__test_get_transactions_output_user_transaction_with_entry_function_payload.json

@@ -25,7 +25,6 @@ aptos-config = { path = "../../config" }
 aptos-crypto = { path = "../../crates/aptos-crypto" }
 aptos-openapi = { path = "../../crates/aptos-openapi" }
 aptos-state-view = { path = "../../storage/state-view" }
-aptos-transaction-builder = { path = "../../sdk/transaction-builder" }
 aptos-types = { path = "../../types" }
 aptos-vm = { path = "../../aptos-move/aptos-vm" }
 

Diff for: api/types/Cargo.toml

@@ -15,7 +15,6 @@ use crate::{
 };
 use anyhow::{bail, ensure, format_err, Context as AnyhowContext, Result};
 use aptos_crypto::{hash::CryptoHash, HashValue};
-use aptos_transaction_builder::error_explain;
 use aptos_types::state_store::table::TableHandle;
 use aptos_types::{
     access_path::{AccessPath, Path},
@@ -678,23 +677,13 @@ impl<'a, R: MoveResolverExt + ?Sized> MoveConverter<'a, R> {
 
     fn explain_vm_status(&self, status: &ExecutionStatus) -> String {
         match status {
-            ExecutionStatus::MoveAbort { location, code} => match &location {
-                AbortLocation::Module(module_id) => {
-                    let explanation = error_explain::get_explanation(module_id, *code);
-                    explanation
-                        .map(|ec| {
-                            // TODO(wrwg): category and reason where removed from Move apis,
-                            //   instead we have only single code_name/description. Need to
-                            //   verify whether error reporting in the api is still reasonable.
-                            format!(
-                                "Move abort by {}\n{}",
-                                ec.code_name,
-                                ec.code_description,
-                            )
-                        })
-                        .unwrap_or_else(|| {
-                            format!("Move abort: code {:#x} at {}", code, location)
-                        })
+            ExecutionStatus::MoveAbort { location, code, info } => match &location {
+                AbortLocation::Module(_) => {
+                    info.as_ref().map(|i| {
+                        format!("Move abort by {}\n{}", i.reason_name, i.description)
+                    }).unwrap_or_else(|| {
+                        format!("Move abort: code {:#x} at {}", code, location)
+                    })
                 }
                 AbortLocation::Script => format!("Move abort: code {:#x}", code),
             },
@@ -717,12 +706,12 @@ impl<'a, R: MoveResolverExt + ?Sized> MoveConverter<'a, R> {
                     func_name, code_offset
                 )
             }
-            ExecutionStatus::MiscellaneousError( code ) => {
+            ExecutionStatus::MiscellaneousError(code) => {
                 code.map_or(
                     "Move bytecode deserialization / verification failed, including entry function not found or invalid arguments".to_owned(),
                     |e| format!(
                         "Transaction Executed and Committed with Error {:#?}", e
-                    )
+                    ),
                 )
             }
         }

Diff for: api/types/src/convert.rs

@@ -34,7 +34,6 @@ vm-genesis = { path = "../vm-genesis" }
 # Other Aptos dependencies
 aptos-crypto = { path = "../../crates/aptos-crypto" }
 aptos-state-view = { path = "../../storage/state-view" }
-aptos-transaction-builder = { path = "../../sdk/transaction-builder" }
 aptos-types = { path = "../../types", features = ["fuzzing"] }
 storage-interface = { path = "../../storage/storage-interface" }
 

Diff for: aptos-move/aptos-transactional-test-harness/Cargo.toml

@@ -501,7 +501,7 @@ impl<'a> AptosTestAdapter<'a> {
         let txn = RawTransaction::new(
             aptos_test_root_address(),
             parameters.sequence_number,
-            aptos_transaction_builder::aptos_stdlib::account_create_account(account_addr),
+            cached_packages::aptos_stdlib::account_create_account(account_addr),
             parameters.max_gas_amount,
             parameters.gas_unit_price,
             parameters.expiration_timestamp_secs,
@@ -517,7 +517,7 @@ impl<'a> AptosTestAdapter<'a> {
         let txn = RawTransaction::new(
             aptos_test_root_address(),
             parameters.sequence_number + 1,
-            aptos_transaction_builder::aptos_stdlib::aptos_coin_mint(account_addr, amount),
+            cached_packages::aptos_stdlib::aptos_coin_mint(account_addr, amount),
             parameters.max_gas_amount,
             parameters.gas_unit_price,
             parameters.expiration_timestamp_secs,

Diff for: aptos-move/aptos-transactional-test-harness/src/aptos_test_harness.rs

@@ -14,6 +14,7 @@ anyhow = "1.0.57"
 aptos-crypto = { path = "../../crates/aptos-crypto" }
 aptos-crypto-derive = { path = "../../crates/aptos-crypto-derive" }
 bcs = "0.1.3"
+dashmap = "5.2.0"
 fail = "0.5.0"
 mirai-annotations = "1.12.0"
 num_cpus = "1.13.1"

Diff for: aptos-move/aptos-vm/Cargo.toml

@@ -29,6 +29,7 @@ use aptos_logger::prelude::*;
 use aptos_module_verifier::module_init::verify_module_init_function;
 use aptos_state_view::StateView;
 use aptos_types::account_config::new_block_event_key;
+use aptos_types::vm_status::AbortLocation;
 use aptos_types::{
     account_config,
     block_metadata::BlockMetadata,
@@ -168,8 +169,25 @@ impl AptosVM {
         log_context: &AdapterLogSchema,
     ) -> (VMStatus, TransactionOutputExt) {
         let mut session = self.0.new_session(storage, SessionId::txn_meta(txn_data));
+        // DNS HERE
         match TransactionStatus::from(error_code.clone()) {
             TransactionStatus::Keep(status) => {
+                // Inject abort info if available.
+                let status = match status {
+                    ExecutionStatus::MoveAbort {
+                        location: AbortLocation::Module(module),
+                        code,
+                        ..
+                    } => {
+                        let info = self.0.extract_abort_info(&module, code);
+                        ExecutionStatus::MoveAbort {
+                            location: AbortLocation::Module(module),
+                            code,
+                            info,
+                        }
+                    }
+                    _ => status,
+                };
                 // The transaction should be charged for gas, so run the epilogue to do that.
                 // This is running in a new session that drops any side effects from the
                 // attempted transaction (e.g., spending funds that were needed to pay for gas),