Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the .dist mapbox gl js directly to minimise webpack configuration #3

Open
cammanderson opened this issue Dec 29, 2016 · 1 comment

Comments

@cammanderson
Copy link
Contributor

Mapbox no longer encourage building of mapbox gl js using webpack. They suggest that their supplied dist version should be directly required.

Examples of the webpack configuration here use alias to map the library to the dist file as needed. This became a "gotcha" (as in issue #2 which could be made smoother.

Update to require the dist file in source completely, minimising the need to set noParse and alias configurations in webpack.

@cammanderson
Copy link
Contributor Author

A consideration for implementing this at the library level is that it locks the build approach to only using the supplied dist file - which is necessary for systemjs and webpack, but not necessary for browserify. Making this change would stop browserify being able to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant