- mention the version number of the package
- write at least one sentence describing the issue
- share the output of
versioninfo()
- indicate if it is a bug report or feature request
- become member of the Telegram channel
- ask for write access
- create a new branch
- push your changes to the branch
- create a draft pull request
- when you think it is ready, mark it as "ready for review" and invite a reviewer
- address the remarks of the reviewer
- check that all tests passed
- merge the pull request, choosing the
squash
option
It is OK to merge your own pull request without review if you are very sure it will not cause any problems. If in doubt, ask on Telegram.
It is OK to push directly to the main
branch for small changes for example fixing a typo in the documentation.
- shall start with capital letter
- imperative form
Examples
- Fix division-by-zero error
- Improve docstrings
- Implement feature #23
- Add function cool_feature()
- use verbs for the names of functions, nouns for types and structs
- for variable and function names use lower case, underscore if needed
- use CamelCase for types and structs
- indent with four spaces
- max 120 char per line
- do NOT use an automated code formatter
- input files: preferably
.yaml
format - CAD geometries:
.obj
files - multi-dimensional arrays:
.mat
files - CSV files can be used for polars for example, but if the polars are part of wing description better have one
.yaml
file that describes all aspects of the wing
Open questions
- what are
.dat
files? - shall we use
.bin
files? - shall we use
.JLD2
files?