Skip to content

Commit d114076

Browse files
committed
Use untyped any() for mocking in S3MultiPartOutputStreamTest
We don't want to check types and non-null in this test
1 parent a85bdf6 commit d114076

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

storage/s3/src/test/java/io/aiven/kafka/tieredstorage/storage/s3/S3MultiPartOutputStreamTest.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ class S3MultiPartOutputStreamTest {
6969

7070
@Test
7171
void sendAbortForAnyExceptionWhileWriting() {
72-
when(mockedS3.initiateMultipartUpload(any(InitiateMultipartUploadRequest.class)))
72+
when(mockedS3.initiateMultipartUpload(any()))
7373
.thenReturn(newInitiateMultipartUploadResult());
7474

7575
final RuntimeException testException = new RuntimeException("test");
76-
when(mockedS3.uploadPart(any(UploadPartRequest.class)))
76+
when(mockedS3.uploadPart(any()))
7777
.thenThrow(testException);
7878

7979
assertThatThrownBy(() -> {
@@ -92,10 +92,10 @@ void sendAbortForAnyExceptionWhileWriting() {
9292

9393
@Test
9494
void sendAbortForAnyExceptionWhenClose() throws Exception {
95-
when(mockedS3.initiateMultipartUpload(any(InitiateMultipartUploadRequest.class)))
95+
when(mockedS3.initiateMultipartUpload(any()))
9696
.thenReturn(newInitiateMultipartUploadResult());
9797

98-
when(mockedS3.uploadPart(any(UploadPartRequest.class)))
98+
when(mockedS3.uploadPart(any()))
9999
.thenThrow(RuntimeException.class);
100100

101101
final S3MultiPartOutputStream out = new S3MultiPartOutputStream(BUCKET_NAME, FILE_KEY, 10, mockedS3);
@@ -117,11 +117,11 @@ void sendAbortForAnyExceptionWhenClose() throws Exception {
117117

118118
@Test
119119
void writesOneByte() throws Exception {
120-
when(mockedS3.initiateMultipartUpload(any(InitiateMultipartUploadRequest.class)))
120+
when(mockedS3.initiateMultipartUpload(any()))
121121
.thenReturn(newInitiateMultipartUploadResult());
122-
when(mockedS3.uploadPart(any(UploadPartRequest.class)))
122+
when(mockedS3.uploadPart(any()))
123123
.thenReturn(newUploadPartResult(1, "SOME_ETAG"));
124-
when(mockedS3.completeMultipartUpload(any(CompleteMultipartUploadRequest.class)))
124+
when(mockedS3.completeMultipartUpload(any()))
125125
.thenReturn(new CompleteMultipartUploadResult());
126126

127127
try (final S3MultiPartOutputStream out = new S3MultiPartOutputStream(BUCKET_NAME, FILE_KEY, 100, mockedS3)) {
@@ -148,14 +148,14 @@ void writesMultipleMessages() throws Exception {
148148
final int bufferSize = 10;
149149
final byte[] message = new byte[bufferSize];
150150

151-
when(mockedS3.initiateMultipartUpload(any(InitiateMultipartUploadRequest.class)))
151+
when(mockedS3.initiateMultipartUpload(any()))
152152
.thenReturn(newInitiateMultipartUploadResult());
153-
when(mockedS3.uploadPart(any(UploadPartRequest.class)))
153+
when(mockedS3.uploadPart(any()))
154154
.thenAnswer(a -> {
155155
final UploadPartRequest up = a.getArgument(0);
156156
return newUploadPartResult(up.getPartNumber(), "SOME_TAG#" + up.getPartNumber());
157157
});
158-
when(mockedS3.completeMultipartUpload(any(CompleteMultipartUploadRequest.class)))
158+
when(mockedS3.completeMultipartUpload(any()))
159159
.thenReturn(new CompleteMultipartUploadResult());
160160

161161
final List<byte[]> expectedMessagesList = new ArrayList<>();
@@ -196,9 +196,9 @@ void writesTailMessages() throws Exception {
196196

197197
final List<UploadPartRequest> uploadPartRequests = new ArrayList<>();
198198

199-
when(mockedS3.initiateMultipartUpload(any(InitiateMultipartUploadRequest.class)))
199+
when(mockedS3.initiateMultipartUpload(any()))
200200
.thenReturn(newInitiateMultipartUploadResult());
201-
when(mockedS3.uploadPart(any(UploadPartRequest.class)))
201+
when(mockedS3.uploadPart(any()))
202202
.thenAnswer(a -> {
203203
final UploadPartRequest up = a.getArgument(0);
204204
//emulate behave of S3 client otherwise we will get wrong array in the memory
@@ -207,7 +207,7 @@ void writesTailMessages() throws Exception {
207207

208208
return newUploadPartResult(up.getPartNumber(), "SOME_ETAG#" + up.getPartNumber());
209209
});
210-
when(mockedS3.completeMultipartUpload(any(CompleteMultipartUploadRequest.class)))
210+
when(mockedS3.completeMultipartUpload(any()))
211211
.thenReturn(new CompleteMultipartUploadResult());
212212

213213
final byte[] message = new byte[messageSize];

0 commit comments

Comments
 (0)