You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Description
Always use `sed -i …` vs. `sed -i ''` as appropriate, with a `sedi` function or alias where possible.
### Security Considerations
n/a
### Scaling Considerations
n/a
### Documentation Considerations
n/a
### Testing Considerations
I haven't found a practical way to test this, so it might go stale—but if so, it's only in development/build tooling so it can be fixed again if that happens.
### Upgrade Considerations
n/a
Copy file name to clipboardexpand all lines: MAINTAINERS.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -95,7 +95,7 @@ For each set of changes to include after the base branch point:
95
95
- If encountering a commit with conflicts that do not have a straightforward resolution, check if picking any prior commit would help resolve the conflicts.
96
96
- Abort the rebase, update the authored `rebase-todo`, and restart the interactive rebase.
97
97
- Avoid authoring manual changes unless absolutely necessary. If authoring changes, keep them as separate commits and indicate them as such on the authored rebase todo (insert either a `pick` instruction with the id of the commit you just authored or an `exec` instruction that makes the modifications and ends with `git commit -m $message`, in either case prefixing with an explanatory `##` comment).
98
-
- For `exec`, make portable in-place edits with either `ed` or `alias sed-i="sed -i $(sed --help 2>&1| sed 2q | grep -qe '-i '&&echo"''")"`, e.g. `printf 'H\n/\( *\)foo/ s##\\1// prettier-ignore\\\n&#\nw\n'| ed -s packages/path/to/file'` or `sed-i -E "$(printf 's#( *)foo#\\1// prettier-ignore\\\n&#')" packages/path/to/file`.
98
+
- For `exec`, make portable in-place edits with either `ed` or `alias sedi="sed -i $(sed --help 2>&1| sed 2q | grep -qe '-i '&&echo"''")"`, e.g. `printf 'H\n/\( *\)foo/ s##\\1// prettier-ignore\\\n&#\nw\n'| ed -s packages/path/to/file'` or `sedi -E "$(printf 's#( *)foo#\\1// prettier-ignore\\\n&#')" packages/path/to/file`.
99
99
- If a commit is empty, skip it and comment it out in the rebase todo.
100
100
- [ ] Verify that tests pass. In particular:
101
101
- Linting locally can catch incompatibilities in the cherry-pick, often requiring some changes to be reverted or more commits from `master` to be included. In those cases, update the authored `rebase-todo`, and redo the interactive rebase as necessary.
0 commit comments