feat: StatusManager tracks seenTxs

- use a composite key of `txHash+chainId` to track unique `EventFeed` submissions

Author: 0xpatrickdev

packages/fast-usdc/src/exos/status-manager.js

@@ -6,9 +6,9 @@ import { CctpTxEvidenceShape, PendingTxShape } from '../typeGuards.js';
 import { TxStatus } from '../constants.js';
 
 /**
- * @import {MapStore} from '@agoric/store';
+ * @import {MapStore, SetStore} from '@agoric/store';
  * @import {Zone} from '@agoric/zone';
- * @import {CctpTxEvidence, NobleAddress, PendingTxKey, PendingTx} from '../types.js';
+ * @import {CctpTxEvidence, NobleAddress, SeenTxKey, PendingTxKey, PendingTx} from '../types.js';
  */
 
 /**
@@ -29,6 +29,15 @@ const getPendingTxKey = evidence => {
   return toPendingTxKey(forwardingAddress, amount);
 };
 
+/**
+ * Get the key for the seenTxs SetStore
+ * @param {CctpTxEvidence} evidence
+ */
+const getSeenKey = evidence => {
+  const { txHash, chainId } = evidence;
+  return /** @type {SeenTxKey} */ (JSON.stringify([txHash, chainId]));
+};
+
 /**
  * The `StatusManager` keeps track of Pending and Seen Transactions
  * via {@link TxStatus} states, aiding in coordination between the `Advancer`
@@ -45,6 +54,25 @@ export const prepareStatusManager = zone => {
     valueShape: M.arrayOf(PendingTxShape),
   });
 
+  /** @type {SetStore<SeenTxKey>} */
+  const seenTxs = zone.setStore('SeenTxs', {
+    keyShape: M.string(),
+  });
+
+  /**
+   * Ensures that `txHash+chainId` has not been processed
+   * and adds `txHash+chainId` to `seenTxs` set.
+   *
+   * @param {CctpTxEvidence} evidence
+   */
+  const assertNotSeen = evidence => {
+    const seenKey = getSeenKey(evidence);
+    if (seenTxs.has(seenKey)) {
+      throw makeError(`Transaction already seen: ${q(seenKey)}`);
+    }
+    seenTxs.add(seenKey);
+  };
+
   return zone.exo(
     'Fast USDC Status Manager',
     M.interface('StatusManagerI', {
@@ -60,6 +88,7 @@ export const prepareStatusManager = zone => {
        * @param {CctpTxEvidence} evidence
        */
       advance(evidence) {
+        assertNotSeen(evidence);
         const key = getPendingTxKey(evidence);
         const entry = { ...evidence, status: TxStatus.Advanced };
 
@@ -76,6 +105,7 @@ export const prepareStatusManager = zone => {
        * @param {CctpTxEvidence} evidence
        */
       observe(evidence) {
+        assertNotSeen(evidence);
         const key = getPendingTxKey(evidence);
         const entry = { ...evidence, status: TxStatus.Observed };
 

packages/fast-usdc/src/types.ts

@@ -32,4 +32,7 @@ export interface PendingTx extends CctpTxEvidence {
 /** composite of NobleAddress and transaction amount value */
 export type PendingTxKey = `"["${NobleAddress}",${bigint}]"`;
 
+/** composite of EvmHash and chainId */
+export type SeenTxKey = `"["${EvmHash}",${number}]"`;
+
 export type * from './constants.js';

packages/fast-usdc/test/exos/status-manager.test.ts

@@ -43,11 +43,13 @@ test('cannot process same tx twice', t => {
   statusManager.advance(evidence);
 
   t.throws(() => statusManager.advance(evidence), {
-    message: `Transaction already seen: "0xc81bc6105b60a234c7c50ac17816ebcd5561d366df8bf3be59ff387552761702+1"`,
+    message:
+      'Transaction already seen: "[[\\"0xc81bc6105b60a234c7c50ac17816ebcd5561d366df8bf3be59ff387552761702\\",1]]"',
   });
 
   t.throws(() => statusManager.observe(evidence), {
-    message: `Transaction already seen: "0xc81bc6105b60a234c7c50ac17816ebcd5561d366df8bf3be59ff387552761702+1"`,
+    message:
+      'Transaction already seen: "[[\\"0xc81bc6105b60a234c7c50ac17816ebcd5561d366df8bf3be59ff387552761702\\",1]]"',
   });
 
   // new txHash should not throw