Fix some Lighthouse suggestions. (#55)

leerob · web-flow · commit 6e3128e25959 · 2022-11-13T12:00:55.000-06:00
diff --git a/app/head.js b/app/head.js
@@ -3,7 +3,14 @@ export default async function Head() {
     <>
       <title>Next.js 13 + React Server Components Demo (Beta)</title>
       <meta name="viewport" content="width=device-width, initial-scale=1" />
+      <meta name="robots" content="follow, index" />
+      <meta
+        name="description"
+        content="Hacker News clone built with Next.js 13 and the app directory (beta)."
+      />
       <meta charSet="utf-8" />
+      <link href="/favicon.ico" rel="shortcut icon" />
+      <meta content="#ffa52a" name="theme-color" />
     </>
-  );
+  )
 }
diff --git a/app/layout.js b/app/layout.js
@@ -1,17 +1,17 @@
-import Header from '../components/header';
+import Header from '../components/header'
 
-import '../styles/globals.css';
-import styles from '../styles/RootLayout.module.css';
+import '../styles/globals.css'
+import styles from '../styles/RootLayout.module.css'
 
 export default function RootLayout({ children }) {
   return (
-    <html>
+    <html lang="en">
       <body>
         <main className={styles.main}>
           <Header />
           <div className={styles.page}>{children}</div>
         </main>
       </body>
     </html>
-  );
-}
+  )
+}
diff --git a/components/header.js b/components/header.js
@@ -1,8 +1,8 @@
-import Nav from './nav';
-import Logo from './logo';
-import Link from 'next/link';
+import Nav from './nav'
+import Logo from './logo'
+import Link from 'next/link'
 
-import styles from './header.module.css';
+import styles from './header.module.css'
 
 export default function Header() {
   return (
@@ -19,10 +19,10 @@ export default function Header() {
         </div>
       </div>
       <div className={styles.right}>
-        <a href="/login" className={styles.login}>
+        <a href="/" className={styles.login}>
           login
         </a>
       </div>
     </header>
-  );
+  )
 }
diff --git a/components/stories.js b/components/stories.js
@@ -1,7 +1,7 @@
-import Story from './story';
-import Link from 'next/link';
+import Story from './story'
+import Link from 'next/link'
 
-import styles from './stories.module.css';
+import styles from './stories.module.css'
 
 export default ({ stories, page = 1, offset = null }) => (
   <div>
@@ -16,9 +16,7 @@ export default ({ stories, page = 1, offset = null }) => (
       </div>
     ))}
     <footer className={styles.footer}>
-      <Link prefetch href={`/news?p=${page + 1}`}>
-        More
-      </Link>
+      <Link href={`/news?p=${page + 1}`}>More</Link>
     </footer>
   </div>
-);
+)
diff --git a/components/story.module.css b/components/story.module.css
@@ -9,7 +9,7 @@
 }
 
 .title > a:visited {
-  color: #828282;
+  color: #757575;
 }
 
 .meta {
@@ -23,7 +23,7 @@
 
 .source a,
 .meta a {
-  color: #828282;
+  color: #757575;
   text-decoration: none;
 }
 
diff --git a/public/favicon.ico b/public/favicon.ico
diff --git a/styles/RootLayout.module.css b/styles/RootLayout.module.css
@@ -4,7 +4,7 @@
 }
 
 .page {
-  color: #828282;
+  color: #757575;
   background: #fff;
   padding: 3px 10px;
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`.title > a:visited {`
`12`		`- color: #828282;`
	`12`	`+ color: #757575;`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`.meta {`
`@@ -23,7 +23,7 @@`
`23`	`23`
`24`	`24`	`.source a,`
`25`	`25`	`.meta a {`
`26`		`- color: #828282;`
	`26`	`+ color: #757575;`
`27`	`27`	`text-decoration: none;`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`.page {`
`7`		`- color: #828282;`
	`7`	`+ color: #757575;`
`8`	`8`	`background: #fff;`
`9`	`9`	`padding: 3px 10px;`
`10`	`10`	`}`