Skip to content

Commit ea0d658

Browse files
authored
Merge pull request #51 from AddSearch/sc-8379/uri-encode-hierarchical-facets-and-range-facets
[sc-8379] encode hierarchicalFacets & rangeFacets parameter
2 parents f81abb2 + 02323ae commit ea0d658

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

dist/addsearch-js-client.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "addsearch-js-client",
3-
"version": "0.8.4",
3+
"version": "0.8.5",
44
"description": "AddSearch API JavaScript client",
55
"main": "index.js",
66
"jsdelivr": "./dist/addsearch-js-client.min.js",

src/apifetch.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ var executeApiFetch = function(apiHostname, sitekey, type, settings, cb, fuzzyRe
8282
settingToQueryParam(settings.numFacets, 'numFacets') +
8383
settingToQueryParam(settings.cacheResponseTime, 'cacheResponseWithTtlSeconds') +
8484
settingToQueryParam(settings.searchOperator, 'defaultOperator') +
85-
settingToQueryParam(settings.analyticsTag, 'analyticsTag') +
86-
settingToQueryParam(settings.hierarchicalFacetSetting, 'hierarchicalFacets');
85+
settingToQueryParam(settings.analyticsTag, 'analyticsTag');
8786

8887
// Add sortBy and sortOrder
8988
if (Array.isArray(settings.paging.sortBy)) {
@@ -113,7 +112,12 @@ var executeApiFetch = function(apiHostname, sitekey, type, settings, cb, fuzzyRe
113112

114113
// Range facets
115114
if (settings.rangeFacets) {
116-
qs = qs + '&rangeFacets=' + JSON.stringify(settings.rangeFacets);
115+
qs = qs + '&rangeFacets=' + encodeURIComponent(JSON.stringify(settings.rangeFacets));
116+
}
117+
118+
// Hierarchical facets
119+
if (settings.hierarchicalFacetSetting) {
120+
qs = qs + '&hierarchicalFacets=' + encodeURIComponent(JSON.stringify(settings.hierarchicalFacetSetting));
117121
}
118122

119123

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ var settings = function() {
176176
}
177177

178178
this.addHierarchicalFacetSetting = function(setting) {
179-
this.settings.hierarchicalFacetSetting = JSON.stringify(setting);
179+
this.settings.hierarchicalFacetSetting = setting;
180180
}
181181

182182
this.addRangeFacet = function(field, ranges) {

0 commit comments

Comments
 (0)