Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Install script in VS code terminal fails to install #75

Open
AdamXweb opened this issue Jun 16, 2022 · 3 comments
Open

[BUG] Install script in VS code terminal fails to install #75

AdamXweb opened this issue Jun 16, 2022 · 3 comments
Labels
🐛 bug Something isn't working 🍎 MacOS Mac Specific

Comments

@AdamXweb
Copy link
Owner

Describe the bug
command using logname to assign user folder within VS code / VSCodium displays root
This causes the rest of install script to fail.
On most MacOS installs, username will be a user.
Considering changing to whoami or other command.

To Reproduce
Steps to reproduce the behavior:

  1. open VS code
  2. option shift ` to activate a new terminal
  3. use install script: bash install.sh

Expected behavior
install script grabs proper username.

Screenshots
Screen Shot 2022-06-16 at 2 27 38 pm

Desktop (please complete the following information):

  • MacOS 12.4
  • VScodiumn 1.67.2
@AdamXweb AdamXweb added the 🐛 bug Something isn't working label Jun 16, 2022
@AdamXweb AdamXweb added the 🍎 MacOS Mac Specific label Jun 30, 2022
@willco007
Copy link

Also fails on Panic Prompt terminal with the same issue. We are investigating on our end how to fix it, but the easy fix is to use whoami instead of logname.

@AdamXweb
Copy link
Owner Author

Hi @willco007, thanks for picking up on this!
I've noticed it in Nova too, which I guess would use the same as you mentioned

Thanks for the suggestion, I've updated the script to use whoami instead

@willco007
Copy link

Confirmed fixed with HEAD, thanks again or the quick fix and the nice work on the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🍎 MacOS Mac Specific
Projects
None yet
Development

No branches or pull requests

2 participants