Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Firefox ESR support #139

Open
joonaskokko opened this issue Jan 1, 2025 · 4 comments
Open

[FEAT] Firefox ESR support #139

joonaskokko opened this issue Jan 1, 2025 · 4 comments
Labels
🦄 enhancement New feature or request 🌈 feedback Feedback relating to experience

Comments

@joonaskokko
Copy link

Is your feature request related to a problem? If so, please describe.

The theme doesn't install for Firefox ESR. After doing a search and replace to the project I managed to change all ""default-release to ""default-esr but for some reason the theme doesn't get enabled. I'm stuck as I couldn't figure out why.

Describe the solution you'd like

The script could also detect an ESR installation.

Priority

Low (Nice-to-have)

Is this something you would be keen to implement

Maybe

@AdamXweb AdamXweb added 🦄 enhancement New feature or request 🌈 feedback Feedback relating to experience labels Jan 1, 2025
@AdamXweb
Copy link
Owner

AdamXweb commented Jan 1, 2025

Thanks for submitting this issue - I'll look into ESR support. Could you confirm which OS and version of firefox you are on?

@joonaskokko
Copy link
Author

I'm on Sequoia 15.2 and Firefox ESR version is 128.5.2esr (64-bit).

I could do a pull request of the installation scripts but my competence ends to the point where the theme doesn't get enabled for some reason. Got it install successfully but the browser theme doesn't change. I also set the toolkit.legacyUserProfileCustomizations.stylesheets.

@AdamXweb
Copy link
Owner

AdamXweb commented Jan 1, 2025

I'll have to look further into it further, as you're correct - the folder for the profile is default-esr not default-release. I'm not sure if firefox ESR respects the configuration/user.js file too.. which could cause some issues. I'll research and come back to this.

Screenshot 2025-01-01 at 10 34 52 PM I was able to get the theme 'working' when changing the legacy stlesheets to true in `about:config` too. image However due to the changes introduced in firefox v133, only up to v1.5.6 is compatible.. Screenshot 2025-01-01 at 10 36 12 PM

There may be a bit more to be done to the install script to make it more streamlined for users on both MacOS and Windows.. As well as for forks of Firefox

Silly question but did you quit and reopen firefox after changing stylesheets to true?

@joonaskokko
Copy link
Author

Yes, I did. Couple of times actually.

But yeah, if ESR needs its own version of the theme then I think it's not really viable to support it. Managing multiple versions seems a bit too much. One possibility is just to wait for ESR to update to a more recent version and then could look into this again with the script changes if it would work out-of-the-box.

Thanks for looking into this tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 enhancement New feature or request 🌈 feedback Feedback relating to experience
Projects
None yet
Development

No branches or pull requests

2 participants